From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752202AbdATNnz (ORCPT ); Fri, 20 Jan 2017 08:43:55 -0500 Received: from mx2.suse.de ([195.135.220.15]:47069 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbdATNnx (ORCPT ); Fri, 20 Jan 2017 08:43:53 -0500 Date: Fri, 20 Jan 2017 14:11:30 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Benjamin Tissoires cc: Bastien Nocera , Peter Hutterer , Nestor Lopez Casado , Olivier Gay , Simon Wood , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/17] HID: logitech-hidpp: Add scope to battery In-Reply-To: <20170117143547.30488-3-benjamin.tissoires@redhat.com> Message-ID: References: <20170117143547.30488-1-benjamin.tissoires@redhat.com> <20170117143547.30488-3-benjamin.tissoires@redhat.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Jan 2017, Benjamin Tissoires wrote: > From: Bastien Nocera > > Without a scope defined, UPower assumes that the battery is provide > power to the computer it's connected to, like a laptop battery or a UPS. > > Tested-by: Peter Hutterer > Signed-off-by: Bastien Nocera > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/hid-logitech-hidpp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > index 4eeb550..4aaf237 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -761,6 +761,7 @@ static int hidpp20_battery_event(struct hidpp_device *hidpp, > static enum power_supply_property hidpp_battery_props[] = { > POWER_SUPPLY_PROP_STATUS, > POWER_SUPPLY_PROP_CAPACITY, > + POWER_SUPPLY_PROP_SCOPE, Actually, what is the code baseline for this patchset please? I don't think I've ever seen hidpp_battery_props[] before. Thanks, -- Jiri Kosina SUSE Labs