From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751249AbdAWOPs (ORCPT ); Mon, 23 Jan 2017 09:15:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:48753 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140AbdAWOPp (ORCPT ); Mon, 23 Jan 2017 09:15:45 -0500 Date: Mon, 23 Jan 2017 15:15:36 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Benjamin Tissoires cc: Dmitry Torokhov , David Herrmann , Oliver Neukum , Jason Gerecke , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] HID: get rid of HID_QUIRK_NO_INIT_REPORTS In-Reply-To: <20170105092144.17120-1-benjamin.tissoires@redhat.com> Message-ID: References: <20170105092144.17120-1-benjamin.tissoires@redhat.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Jan 2017, Benjamin Tissoires wrote: > I don't know what to do about hiddev too. I don't know if we have actual > users besides some debugging tools. And hidraw is much better than > hiddev, so ideally, I'd like to remove it some way. First, I'd love to get rid of HID_QUIRK_NO_INIT_REPORTS; I am whole-heartedly convinced that initializing reports was a big mistake to start with, but changing history is hard :) Regarding hiddev -- there actually are 'legitimate' non-debug users; for example NUT (UPS management software) has been using it last time I looked. I am pretty sure there are more. So we'd rather be careful not to break hiddev by default. I'll think about your RFC a little bit more. Thanks, -- Jiri Kosina SUSE Labs