From: Jiri Kosina <jkosina@suse.cz>
To: Matt Fleming <matt@codeblueprint.co.uk>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Waiman Long <waiman.long@hpe.com>, Borislav Petkov <bp@suse.de>,
Laura Abbott <labbott@redhat.com>,
Vojtech Pavlik <vojtech@ucw.cz>, Hanka Pavlikova <hanka@ucw.cz>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org
Subject: Re: [PATCH] x86/efi: always map first physical page into EFI pagetables
Date: Wed, 25 Jan 2017 21:31:53 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.20.1701252130410.25515@cbobk.fhfr.pm> (raw)
In-Reply-To: <alpine.LSU.2.20.1701252048550.25515@cbobk.fhfr.pm>
[ CCing mailinglists that got eaten by my newly configured mail setup,
sorry for that ]
On Wed, 25 Jan 2017, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> Commit 129766708 ("x86/efi: Only map RAM into EFI page tables if in
> mixed-mode") stopped creating 1:1 mapping for all RAM in case of running
> in native 64bit mode.
>
> It turns out though that there are 64bit EFI implementations in the wild
> (this particular problem has been reported on Lenovo Yoga 710-11IKB) which
> still make use of first physical page for their own private use (which is
> what legacy BIOS used to do, but EFI specification doesn't grant any such
> right to EFI BIOS ... oh well).
>
> In case there is no mapping for this particular frame in EFI pagetables,
> as soon as firmware tries to make use of it, triple fault occurs and the
> system reboots (in case of Yoga 710-11IKB this is very early during boot).
>
> Fix that by always mapping the first page of physical memory into EFI
> pagetables.
>
> Note: just reverting 129766708 is not enough on v4.9-rc1+ to fix the
> regression on affected hardware, as commit ab72a27da ("x86/efi:
> Consolidate region mapping logic") later made the first physical frame not
> to be mapped anyway.
>
> Fixes: 129766708 ("x86/efi: Only map RAM into EFI page tables if in mixed-mode")
> Cc: stable@kernel.org # v4.8+
> Cc: Waiman Long <waiman.long@hpe.com>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Laura Abbott <labbott@redhat.com>
> Cc: Vojtech Pavlik <vojtech@ucw.cz>
> Reported-by: Hanka Pavlikova <hanka@ucw.cz>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---
>
> Thanks a lot to Matt for excellent hint how to debug EFI failures
>
> arch/x86/platform/efi/efi_64.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c
> index 319148b..02ae2ab 100644
> --- a/arch/x86/platform/efi/efi_64.c
> +++ b/arch/x86/platform/efi/efi_64.c
> @@ -269,6 +269,17 @@ int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned num_pages)
> efi_scratch.use_pgd = true;
>
> /*
> + * Certain firmware versions are way too sentimental and still believe
> + * they are exclusive and unquestionable owners of first physical page.
> + * Create 1:1 mapping for this page to avoid triple faults during early
> + * boot with such firmware.
> + */
> + if (kernel_map_pages_in_pgd(pgd, 0x0, 0x0, 1, _PAGE_RW)) {
> + pr_err("Failed to create 1:1 mapping of first page\n");
> + return 1;
> + }
> +
> + /*
> * When making calls to the firmware everything needs to be 1:1
> * mapped and addressable with 32-bit pointers. Map the kernel
> * text and allocate a new stack because we can't rely on the
> --
> Jiri Kosina
> SUSE Labs
>
>
--
Jiri Kosina
SUSE Labs
next parent reply other threads:[~2017-01-25 20:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LSU.2.20.1701252048550.25515@cbobk.fhfr.pm>
2017-01-25 20:31 ` Jiri Kosina [this message]
2017-01-25 20:36 ` Borislav Petkov
2017-01-27 15:12 ` Matt Fleming
2017-01-27 15:39 ` [PATCH v2] " Jiri Kosina
2017-01-27 16:23 ` Matt Fleming
2017-01-27 22:06 [GIT PULL] EFI urgent fix Matt Fleming
2017-01-27 22:25 ` [PATCH] x86/efi: Always map first physical page into EFI pagetables Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1701252130410.25515@cbobk.fhfr.pm \
--to=jkosina@suse.cz \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@suse.de \
--cc=hanka@ucw.cz \
--cc=labbott@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=vojtech@ucw.cz \
--cc=waiman.long@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®