From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753547AbdBKHz5 (ORCPT ); Sat, 11 Feb 2017 02:55:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:35080 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbdBKHzz (ORCPT ); Sat, 11 Feb 2017 02:55:55 -0500 Date: Sat, 11 Feb 2017 08:54:59 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Denys Fedoryshchenko cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Josh Poimboeuf , Jessica Yu , Miroslav Benes Subject: Re: Mistake in include IS_ENABLED(CONFIG_LIVEPATCH) In-Reply-To: <99aec04ff3cedcf82af22ab147e77225@nuclearcat.com> Message-ID: References: <99aec04ff3cedcf82af22ab147e77225@nuclearcat.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Feb 2017, Denys Fedoryshchenko wrote: > I noticed that sample of livepatch is not working in 4.9.9, because in > include, > linux/livepatch.h > it is: > #if IS_ENABLED(CONFIG_LIVEPATCH) > > while config option is: > CONFIG_HAVE_LIVEPATCH=y > > After editing livepatch.h sample module compiles fine > > Probably that's just a typo? There are two config variables. CONFIG_HAVE_LIVEPATCH is set by those architectures for which livepatching implementation exists. CONFIG_LIVEPATCH is the actual config option turning the support in kernel on/off. What you are seeing is that if you have kernel configuration that has livepatching (CONFIG_LIVEPATCH) turned off, the sample module doesn't compile for it either. I'd say it's not unexpected behavior. -- Jiri Kosina SUSE Labs