From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753220AbdBNOes (ORCPT ); Tue, 14 Feb 2017 09:34:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:43460 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753236AbdBNOdf (ORCPT ); Tue, 14 Feb 2017 09:33:35 -0500 Date: Tue, 14 Feb 2017 15:33:32 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Bhumika Goyal cc: julia.lawall@lip6.fr, srinivas.pandruvada@linux.intel.com, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: intel-ish-hid: constify device_type structure In-Reply-To: <1486797037-31415-1-git-send-email-bhumirks@gmail.com> Message-ID: References: <1486797037-31415-1-git-send-email-bhumirks@gmail.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Feb 2017, Bhumika Goyal wrote: > Declare device_type structure as const as it is only stored in the > type field of a device structure. This field is of type const, so add > const to the declaration of device_type structure. > > File size before: drivers/hid/intel-ish-hid/ishtp/bus.o > text data bss dec hex filename > 4260 336 16 4612 1204 hid/intel-ish-hid/ishtp/bus.o > > File size after: drivers/hid/intel-ish-hid/ishtp/bus.o > text data bss dec hex filename > 4324 272 16 4612 1204 hid/intel-ish-hid/ishtp/bus.o > > Signed-off-by: Bhumika Goyal > --- > drivers/hid/intel-ish-hid/ishtp/bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c > index f4cbc74..5f382fe 100644 > --- a/drivers/hid/intel-ish-hid/ishtp/bus.c > +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c > @@ -358,7 +358,7 @@ static void ishtp_cl_dev_release(struct device *dev) > kfree(to_ishtp_cl_device(dev)); > } > > -static struct device_type ishtp_cl_device_type = { > +static const struct device_type ishtp_cl_device_type = { > .release = ishtp_cl_dev_release, > }; Applied to hid.git#for-4.11/intel-ish, thanks. -- Jiri Kosina SUSE Labs