From: Jiri Kosina <jikos@kernel.org>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
David Herrmann <dh.herrmann@googlemail.com>,
Oliver Neukum <oneukum@suse.de>,
Jason Gerecke <killertofu@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] HID: get rid of HID_QUIRK_NO_INIT_REPORTS
Date: Mon, 6 Mar 2017 13:15:27 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.20.1703061310380.31814@cbobk.fhfr.pm> (raw)
In-Reply-To: <20170105092144.17120-1-benjamin.tissoires@redhat.com>
On Thu, 5 Jan 2017, Benjamin Tissoires wrote:
> For case 1, the hiddev documentation provides an ioctl to do the
> init manually. A solution could be to retrieve the requested report
> when EVIOCGUSAGE is called, in the same way hidraw does. I would be
> tempted to not change the behavior and hope that we won't break any
> userspace tool.
I'd like to be applying the HID_QUIRK_NO_INIT_REPORTS removal as soon as
possible so that it gets exposure in linux-next over the whole development
cycle.
I am however too conservative to ignore the potential hiddev breakage, I
am afraid. This has a real potential of breaking systems, and
administrators having hard time figuring out of happened; essentialy, this
is userspace-visible behavior change (regression) for which we haven't
done any long-term depreciation (such as printing a warning "please talk
to your hiddev driver vendor" in case the driver seems to assume
initialized reports) at least for a few years.
I think that either doing it at a connect time, or during first
EVIOCGUSAGE ioctl() call is a must.
Otherwise, I'd be super-happy to finally get rid of this giant PITA.
Thanks!
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2017-03-06 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 9:21 Benjamin Tissoires
2017-01-23 14:15 ` Jiri Kosina
2017-03-06 12:15 ` Jiri Kosina [this message]
2017-03-06 13:48 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1703061310380.31814@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dh.herrmann@googlemail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=killertofu@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®