From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753817AbdCFMSS (ORCPT ); Mon, 6 Mar 2017 07:18:18 -0500 Received: from mx2.suse.de ([195.135.220.15]:52922 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753762AbdCFMSN (ORCPT ); Mon, 6 Mar 2017 07:18:13 -0500 Date: Mon, 6 Mar 2017 13:18:04 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Benjamin Tissoires cc: Bastien Nocera , Peter Hutterer , Nestor Lopez Casado , Olivier Gay , Simon Wood , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in power_supply In-Reply-To: <20170207083557.GD16529@mail.corp.redhat.com> Message-ID: References: <20170202141229.17322-1-benjamin.tissoires@redhat.com> <20170202141229.17322-6-benjamin.tissoires@redhat.com> <1486134491.2316.11.camel@hadess.net> <20170207083557.GD16529@mail.corp.redhat.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Feb 2017, Benjamin Tissoires wrote: > > > +               case POWER_SUPPLY_PROP_MANUFACTURER: > > > +                       val->strval = "Logitech, Inc."; > > > > I don't like this change. I'd prefer the concatenated manufacturer and > > model strings leading to user-friendly strings, and "Logitech T650" is > > better than "Logitech, Inc. T650". > > Is this the only problematic issue? We are at rc7 already so I would > like to have the final version ready ASAP. Bastien, do you have any input on the rest of the series please? Thanks, -- Jiri Kosina SUSE Labs