From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932071AbdCFMzc (ORCPT ); Mon, 6 Mar 2017 07:55:32 -0500 Received: from mx2.suse.de ([195.135.220.15]:56131 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753156AbdCFMzX (ORCPT ); Mon, 6 Mar 2017 07:55:23 -0500 Date: Mon, 6 Mar 2017 13:55:21 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Oscar Campos cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] HID: Corsair Scimitar Pro RGB gaming mouse driver and support for other Corsair devices In-Reply-To: <20170210182234.GA18830@ManjaroStation> Message-ID: References: <20170210182234.GA18830@ManjaroStation> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Feb 2017, Oscar Campos wrote: > Since I have a Corsair Scimitar PRO RGB that does not works on Linux, I > tried to find a solution doing some research but was not able to find any. [ ... snip ... ] > > I created the new mouse driver instead of add code to the already existent > `hid-corsair.c` as it seem quite common to split mouse and keyboard driver > support. Hi Oscar, thanks a lot for the patch. Keeping the support in hid-corsair would be prefered. I think the only driver where we have the major kbd/mouse split is Holtek, which if I remember correctly was my fault not having catched this during review; it should probably eventually be unified. Otherwsie, we don't really distinguish the device type (the HID land is much wider than mice and keyboards anyway), but in most cases by the vendor. Could you please resubmit the patch so that it's actually adding changes to hid-corsair? Thanks! -- Jiri Kosina SUSE Labs