From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753464AbdCFM53 (ORCPT ); Mon, 6 Mar 2017 07:57:29 -0500 Received: from mx2.suse.de ([195.135.220.15]:56236 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752887AbdCFM5T (ORCPT ); Mon, 6 Mar 2017 07:57:19 -0500 Date: Mon, 6 Mar 2017 13:57:10 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Oscar Campos cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] HID: corsair: Add driver Scimitar Pro RGB gaming mouse 1b1c:1b3e In-Reply-To: <20170210182324.GA21762@ManjaroStation> Message-ID: References: <20170210182324.GA21762@ManjaroStation> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Feb 2017, Oscar Campos wrote: > This mouse sold by Corsair as Scimitar PRO RGB defines two consecutive > Logical Minimum items in its Application (Consumer.0001) report making > it non parseable. This driver fixes the report descriptor overriding > byte 77 in rdesc from 0x16 (Logical Minimum with 16 bits value) to 0x26 > (Logical Maximum with 16 bits value). > > Signed-off-by: Oscar Campos > --- > drivers/hid/Kconfig | 10 ++++++ > drivers/hid/Makefile | 1 + > drivers/hid/hid-corsair-mouse.c | 76 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 87 insertions(+) > create mode 100644 drivers/hid/hid-corsair-mouse.c > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index 4070b7386e9d..1ad179b70b15 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -191,6 +191,16 @@ config HID_CORSAIR > Supported devices: > - Vengeance K90 > > +config HID_CORSAIR_MOUSE: The colon after the symbol name shouldn't be there. [ ... snip ... ] > +static const struct hid_device_id corsair_mouse_devices[] = { > + { HID_USB_DEVICE(USB_VENDOR_ID_CORSAIR, > + USB_DEVICE_ID_CORSAIR_SCIMITAR_PRO_RGB) }, > + { } > +}; > +MODULE_DEVICE_TABLE(hid, corsair_mouse_devices); You need to add this vendor/product id also into hid_have_special_driver[] array, otherwise it's not guaranteed that your driver will bind to it (as the generic one might overrride). Thanks, -- Jiri Kosina SUSE Labs