From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753485AbdCFNms (ORCPT ); Mon, 6 Mar 2017 08:42:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:59700 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbdCFNlw (ORCPT ); Mon, 6 Mar 2017 08:41:52 -0500 Date: Mon, 6 Mar 2017 14:40:58 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Joe Perches cc: Benjamin Tissoires , linux-usb@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: usbhid: Use pr_ and remove unnecessary OOM messages In-Reply-To: <17564e41463d71d65783b11cb0b337363f90eecc.1488418441.git.joe@perches.com> Message-ID: References: <17564e41463d71d65783b11cb0b337363f90eecc.1488418441.git.joe@perches.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Mar 2017, Joe Perches wrote: > Use a more common logging style and remove the unnecessary > OOM messages as there is default dump_stack when OOM. > > Miscellanea: > > o Hoist an assignment in an if > o Realign arguments > o Realign a deeply indented if descendent above a printk > > Signed-off-by: Joe Perches Applied to for-4.12/upstream. Thanks, -- Jiri Kosina SUSE Labs