From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757707AbdCUOAi (ORCPT ); Tue, 21 Mar 2017 10:00:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:35343 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757689AbdCUOAf (ORCPT ); Tue, 21 Mar 2017 10:00:35 -0400 Date: Tue, 21 Mar 2017 15:00:32 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Benjamin Tissoires cc: Dmitry Torokhov , David Herrmann , Oliver Neukum , Jason Gerecke , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2] HID: remove initial reading of reports at connect In-Reply-To: <20170308141114.9200-1-benjamin.tissoires@redhat.com> Message-ID: References: <20170308141114.9200-1-benjamin.tissoires@redhat.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Mar 2017, Benjamin Tissoires wrote: > It looks like a bunch of devices do not like to be polled for their > reports at init time. When you look into the details, it seems that for > those that are requiring the quirk HID_QUIRK_NO_INIT_REPORTS, the driver > fails to retrieve part of the features/inputs while others (more > generic) work. > > IMO, it should be acceptable to remove the need for the quirk in the > general case. On the small amount of cases where we actually need to > read the current values, the driver in charge (hid-mt or wacom) already > retrieves the features manually. Applied to for-4.12/nuke-no-init-reports-quirk. Thanks, -- Jiri Kosina SUSE Labs