From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932666AbdC3Jb3 (ORCPT ); Thu, 30 Mar 2017 05:31:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:37883 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932265AbdC3Jb2 (ORCPT ); Thu, 30 Mar 2017 05:31:28 -0400 Date: Thu, 30 Mar 2017 11:31:24 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Aaron Armstrong Skomra cc: linux-input@vger.kernel.org, pinglinux@gmail.com, killertofu@gmail.com, linux-kernel@vger.kernel.org, Aaron Armstrong Skomra Subject: Re: [PATCH] HID: wacom: Don't add ghost interface as shared data In-Reply-To: <1490808939-22398-1-git-send-email-skomra@gmail.com> Message-ID: References: <1490808939-22398-1-git-send-email-skomra@gmail.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Mar 2017, Aaron Armstrong Skomra wrote: > A previous commit (below) adds a check for already probed interfaces to > Wacom's matching heuristic. Unfortunately this causes the Bamboo Pen > (CTL-460) to match itself to its 'ghost' touch interface. After > subsequent changes to the driver this match to the ghost causes the > kernel to crash. This patch avoids calling wacom_add_shared_data() > for the BAMBOO_PEN's ghost touch interface. > > Fixes: 41372d5d40e7 ("HID: wacom: Augment 'oVid' and 'oPid' with heuristics for HID_GENERIC") > Cc: stable # 4.9 > Signed-off-by: Aaron Armstrong Skomra Applied to for-4.11/upstream-fixes. -- Jiri Kosina SUSE Labs