From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933269AbdDFSe4 (ORCPT ); Thu, 6 Apr 2017 14:34:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:49230 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323AbdDFSeq (ORCPT ); Thu, 6 Apr 2017 14:34:46 -0400 Date: Thu, 6 Apr 2017 20:34:44 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Colin King cc: Benjamin Tissoires , linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: sony: remove redundant check for -ve err In-Reply-To: <20170327175118.28322-1-colin.king@canonical.com> Message-ID: References: <20170327175118.28322-1-colin.king@canonical.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Mar 2017, Colin King wrote: > From: Colin Ian King > > err is being checked for failure each time it is being updated > so this err check is totally redundant and can be removed > > Detected with CoverityScan, CID#1420665 ("Logically dead code") > > Signed-off-by: Colin Ian King Applied to for-4.12/sony. -- Jiri Kosina SUSE Labs