From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753276AbdDKSzk (ORCPT ); Tue, 11 Apr 2017 14:55:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:46550 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752612AbdDKSzh (ORCPT ); Tue, 11 Apr 2017 14:55:37 -0400 Date: Tue, 11 Apr 2017 20:55:35 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Petr Mladek cc: Josh Poimboeuf , Miroslav Benes , Jessica Yu , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH] livepatch: Cancel transition a safe way for immediate patches In-Reply-To: <1491908868-27766-1-git-send-email-pmladek@suse.com> Message-ID: References: <1491908868-27766-1-git-send-email-pmladek@suse.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Apr 2017, Petr Mladek wrote: > klp_init_transition() does not set func->transition for immediate patches. > Then klp_ftrace_handler() could use the new code immediately. As a result, > it is not safe to put the livepatch module in klp_cancel_transition(). > > This patch reverts most of the last minute changes klp_cancel_transition(). > It keeps the warning about a misuse because it still makes sense. > > Signed-off-by: Petr Mladek > --- > Hi, > > I am afraid that Mirek was not right in the mail > https://lkml.kernel.org/r/alpine.LSU.2.20.1702161504020.16310@pobox.suse.cz > IMHO, it is not safe to put the module when the immediate > patch cannot be applied. That's a very good catch indeed, thanks. Applied. -- Jiri Kosina SUSE Labs