From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754890AbdERNtC (ORCPT ); Thu, 18 May 2017 09:49:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:43650 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751731AbdERNs5 (ORCPT ); Thu, 18 May 2017 09:48:57 -0400 Date: Thu, 18 May 2017 15:48:55 +0200 (CEST) From: Miroslav Benes To: Steven Rostedt cc: "Paul E. McKenney" , LKML , Ingo Molnar , Thomas Gleixner Subject: Re: [PATCH v2] tracing: Make sure RCU is watching before calling a stack trace In-Reply-To: <20170518093809.13428efa@gandalf.local.home> Message-ID: References: <20170518093809.13428efa@gandalf.local.home> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 May 2017, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > As stack tracing now requires "rcu watching", force RCU to be watching when > recording a stack trace. > > Link: http://lkml.kernel.org/r/20170512172449.879684501@goodmis.org > > Cc: "Paul E. McKenney" > Signed-off-by: Steven Rostedt (VMware) > --- > > Changes since v1: > > My testing discovered that the stack trace can be called with > interrupts enabled, which is a no no to have when calling > rcu_irq_enter(). When interrupts are enabled, as with being in an > NMI, RCU will also be watching. Would rcu_irq_enter_irqson() help then? This is what Petr used in a live patching handler. Your solution works too, of course. Just asking if I am not missing something. Thanks, Miroslav