From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751065AbdESHvw (ORCPT <rfc822;w@1wt.eu>);
        Fri, 19 May 2017 03:51:52 -0400
Received: from mx2.suse.de ([195.135.220.15]:35497 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1750731AbdESHvv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 19 May 2017 03:51:51 -0400
Date: Fri, 19 May 2017 09:51:48 +0200 (CEST)
From: Miroslav Benes <mbenes@suse.cz>
To: Oleg Nesterov <oleg@redhat.com>
cc: jpoimboe@redhat.com, jeyu@redhat.com, jikos@kernel.org,
        pmladek@suse.com, live-patching@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] livepatch: send a fake signal to all blocking
 tasks
In-Reply-To: <20170518195255.GA2518@redhat.com>
Message-ID: <alpine.LSU.2.20.1705190950440.31456@pobox.suse.cz>
References: <20170518120043.7205-1-mbenes@suse.cz> <20170518120043.7205-3-mbenes@suse.cz> <20170518164909.GA939@redhat.com> <alpine.LSU.2.20.1705182011410.17317@pobox.suse.cz> <20170518195255.GA2518@redhat.com>
User-Agent: Alpine 2.20 (LSU 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> > If not, we get back to exit_to_usermode_loop() and TIF_PATCH_PENDING is 
> > cleared. Yes, it is true that TIF_SIGPENDING is still set and we get to
> > do_signal() once more. But for the last time.
> 
> Yes, slightly sub-optimal but not really wrong and you can swap
> do_signal() and klp_update_patch_state().

Ok. I'll add it to v2.
 
> > If the syscall is restarted, it may be different. I have to think about
> > this one. But...
> 
> Afaics, there are no problems.
> 
> 
> In short. Thanks for correcting me and sorry for noise!

Thanks for the review, Oleg. Much appreciated.

Miroslav