From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758957AbdEVLea (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 May 2017 07:34:30 -0400
Received: from mx2.suse.de ([195.135.220.15]:44853 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751979AbdEVLe2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 May 2017 07:34:28 -0400
Date: Mon, 22 May 2017 13:34:24 +0200 (CEST)
From: Jiri Kosina <jikos@kernel.org>
X-X-Sender: jkosina@pobox.suse.cz
To: "H.J. Lu" <hjl.tools@gmail.com>
cc: Andy Lutomirski <luto@kernel.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jiri Slaby <jslaby@suse.cz>, Andrew Morton <akpm@linux-foundation.org>,
        live-patching@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 7/7] DWARF: add the config option
In-Reply-To: <CAMe9rOoAuqhY_+G=8Dwrt6aJ7YXTwcHShxLEVzt6MeNYAhT9PA@mail.gmail.com>
Message-ID: <alpine.LSU.2.20.1705221333150.26873@cbobk.fhfr.pm>
References: <20170505122200.31436-1-jslaby@suse.cz> <20170505122200.31436-7-jslaby@suse.cz> <CA+55aFzEF_A1MzH8P8EX35FSci7UFj_+5LdsEFVai1DYtCk-Hg@mail.gmail.com> <20170507165524.cdxfuwbd5alr7v6k@treble> <20170519205354.caeyqri2k6gvso3w@treble>
 <8dbbb971-fc41-fba2-f356-931a7eabe6ef@zytor.com> <20170519212913.otir6mlujoxoy3ha@treble> <20170519213556.pv5kxocfprfkloay@treble> <CALCETrWxwhKvm2jYG+d2xupd6uuEDAeBkafPonYNhxF6O=+qVA@mail.gmail.com> <20170520162034.fcciinh3nw5mvad5@treble>
 <CAMe9rOpHtXtcaPza8e2eU-aoeLfqhErV_23rPpM86YGnOWud4A@mail.gmail.com> <CALCETrUy_CX1qe5iBEXWveXtk1EA=Di22L0ZtuHKnTLyxW+x3g@mail.gmail.com> <CAMe9rOoAuqhY_+G=8Dwrt6aJ7YXTwcHShxLEVzt6MeNYAhT9PA@mail.gmail.com>
User-Agent: Alpine 2.20 (LSU 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 20 May 2017, H.J. Lu wrote:

> >>>> pushq %whatever
> >>>> .cfi_adjust_sp -8
> >>>> ...
> >>>> popq %whatever
> >>>> .cfi_adjust_sp 8
> >>>>
> >>
> >> Np.  Compiler needs to generate this.
> >>
> >
> > How would the compiler generate this when inline asm is involved?  For
> > the kernel, objtool could get around the need to have these
> > annotations, but not so much for user code?  Is the compiler supposed
> > to parse the inline asm?  Would the compiler provide some magic % code
> > to represent the current CFA base register?
> 
> Here is one example of inline asm with call frame info:
> 
> https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/x86_64/sigaction.c;h=be058bac436d1cc9794b2b03107676ed99f6b872;hb=HEAD

That brings us basically pretty close to square one though; having to 
maintain "manual" anotations. Something we're pretty much trying to avoid 
through this excercise.

-- 
Jiri Kosina
SUSE Labs