From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751109AbdE2J0q (ORCPT ); Mon, 29 May 2017 05:26:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:34745 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750938AbdE2J0o (ORCPT ); Mon, 29 May 2017 05:26:44 -0400 Date: Mon, 29 May 2017 11:26:42 +0200 (CEST) From: Miroslav Benes To: Josh Poimboeuf cc: jeyu@redhat.com, jikos@kernel.org, pmladek@suse.com, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] livepatch: force transition process to finish In-Reply-To: <20170526173846.euu6dmmo6ghc3bky@treble> Message-ID: References: <20170518120043.7205-1-mbenes@suse.cz> <20170518120043.7205-4-mbenes@suse.cz> <20170526173846.euu6dmmo6ghc3bky@treble> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 May 2017, Josh Poimboeuf wrote: > On Thu, May 18, 2017 at 02:00:43PM +0200, Miroslav Benes wrote: > > @@ -591,3 +591,19 @@ void klp_send_fake_signal(void) > > } > > read_unlock(&tasklist_lock); > > } > > + > > +/* > > + * Drop TIF_PATCH_PENDING of all tasks on admin's request. This forces an > > + * existing transition to finish. > > + */ > > +void klp_unmark_tasks(void) > > +{ > > + struct task_struct *g, *task; > > + > > + pr_warn("all tasks marked as migrated on admin's request\n"); > > + > > + read_lock(&tasklist_lock); > > + for_each_process_thread(g, task) > > + klp_update_patch_state(task); > > + read_unlock(&tasklist_lock); > > +} > > Should this also force the idle tasks to transition? Yes. Thanks. Miroslav