From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751172AbdFBMOW (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Jun 2017 08:14:22 -0400
Received: from mx2.suse.de ([195.135.220.15]:41850 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751125AbdFBMOV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Jun 2017 08:14:21 -0400
Date: Fri, 2 Jun 2017 14:14:18 +0200 (CEST)
From: Jiri Kosina <jikos@kernel.org>
X-X-Sender: jkosina@pobox.suse.cz
To: Carlo Caione <carlo@caione.org>
cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux@endlessm.com,
        Carlo Caione <carlo@endlessm.com>
Subject: Re: [PATCH] HID: asus: Stop underlying hardware on remove
In-Reply-To: <20170530203946.9346-1-carlo@caione.org>
Message-ID: <alpine.LSU.2.20.1706021414080.30709@cbobk.fhfr.pm>
References: <20170530203946.9346-1-carlo@caione.org>
User-Agent: Alpine 2.20 (LSU 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 30 May 2017, Carlo Caione wrote:

> From: Carlo Caione <carlo@endlessm.com>
> 
> We are missing a call to hid_hw_stop() on the remove hook.
> Among other things this is causing an Oops when (re-)starting GNOME /
> upowerd / ... after the module has been already rmmod-ed.
> 
> Signed-off-by: Carlo Caione <carlo@endlessm.com>

Applied to for-4.12/upstream-fixes, thanks.

-- 
Jiri Kosina
SUSE Labs