From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752371AbdGMOv1 (ORCPT ); Thu, 13 Jul 2017 10:51:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:44786 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751193AbdGMOvZ (ORCPT ); Thu, 13 Jul 2017 10:51:25 -0400 Date: Thu, 13 Jul 2017 16:51:22 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Dmitry Torokhov cc: Benjamin Tissoires , Matthias Fend , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: multitouch: do not blindly set EV_KEY or EV_ABS bits In-Reply-To: <20170711170218.GA30175@dtor-ws> Message-ID: References: <20170711170218.GA30175@dtor-ws> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Jul 2017, Dmitry Torokhov wrote: > Now that input core insists on having dev->absinfo when device claims to > generate EV_ABS in its dev->evbit, we should not be blindly setting that > bit. > > The code in question might have been needed before input_set_abs_params() > started setting EV_ABS in device's evbit, but not anymore, and is now > breaking devices such as SMART SPNL-6075 Touchscreen. > > Fixes: 6ecfe51b4082 ("Input: refuse to register absolute devices ...") > Reported-by: Matthias Fend > Tested-by: Matthias Fend > Cc: stable@vger.kernel.org > Signed-off-by: Dmitry Torokhov > --- > > Jiri, Benjamin, I marked it for stable as it causes regressions in 4.12 > reported by users. Please take a look. Thanks for a quick fix, Dmitry. Queued in for-4.13/upstream-fixes branch. -- Jiri Kosina SUSE Labs