From: Jiri Kosina <jikos@kernel.org>
To: "Coelho, Luciano" <luciano.coelho@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linuxwifi <linuxwifi@intel.com>,
"Zhang, Rui" <rui.zhang@intel.com>,
"edubezval@gmail.com" <edubezval@gmail.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Weinehall, David" <david.weinehall@intel.com>,
"Berg, Johannes" <johannes.berg@intel.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"Sharon, Sara" <sara.sharon@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Subject: Re: [linuxwifi] x86/thermal: AB-BA dependency between mvm->mutex and tz->lock
Date: Thu, 3 Aug 2017 13:34:25 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.20.1708031330570.30597@cbobk.fhfr.pm> (raw)
In-Reply-To: <1501759724.15969.49.camel@intel.com>
On Thu, 3 Aug 2017, Coelho, Luciano wrote:
> Okay, so as I understand it the problem has been there for a long time,
> but the splat is only coming up now because of Thomas' patch that adds
> the lockdep map[1], right?
Yeah, sorry, forgot to mention that pre-49dfe2a67797 kernels wouldn't
produce this, as there would not be aware of the fact that
cpus_read_lock() is actually semantically a lock.
> I see the workqueue allocation you mentioned. I'll try to move this
> allocation out of the mutex and see how it goes.
I have been briefly looking into this as well -- it'll basically have to
be moved out of the trans_pcie->mutex context, but
(a) I'm not sure whether that's actually safe
(b) iwl_pcie_rx_reuse_rbd() (which is where corresponding work is being
queued) is not a proper context either (it's atomic context)
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2017-08-03 11:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 11:18 Jiri Kosina
2017-08-03 9:10 ` Jiri Kosina
2017-08-03 9:43 ` [linuxwifi] " Coelho, Luciano
2017-08-03 10:02 ` Kalle Valo
2017-08-03 11:28 ` Coelho, Luciano
2017-08-03 11:34 ` Jiri Kosina [this message]
2017-08-03 13:09 ` Jiri Kosina
2017-08-17 13:38 ` Jiri Kosina
2017-08-17 14:02 ` Coelho, Luciano
2017-08-22 7:32 ` [PATCH] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc() Luca Coelho
2017-08-22 7:37 ` [PATCH v2] " Luca Coelho
2017-08-24 6:00 ` Luca Coelho
2017-08-24 19:56 ` Jiri Kosina
2017-08-24 20:00 ` Luca Coelho
2017-08-29 8:19 ` Kalle Valo
2017-09-04 11:43 ` Jiri Kosina
2017-09-04 11:44 ` Luca Coelho
2017-08-24 13:50 ` [v2] " Kalle Valo
2017-08-30 14:57 ` [PATCH v2] " David Weinehall
2017-08-31 6:11 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1708031330570.30597@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=david.weinehall@intel.com \
--cc=edubezval@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=rui.zhang@intel.com \
--cc=sara.sharon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®