From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753478AbdK1PNO (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 10:13:14 -0500
Received: from er-systems.de ([148.251.68.21]:40826 "EHLO er-systems.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752905AbdK1PNN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 10:13:13 -0500
Date: Tue, 28 Nov 2017 16:13:08 +0100 (CET)
From: Thomas Voegtle <tv@lio96.de>
X-X-Sender: thomas@er-systems.de
To: Daniel Vetter <daniel@ffwll.ch>
cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
        stable@vger.kernel.org
Subject: Re: [PATCH] drm/fb_helper: Disable all crtc's when initial setup
 fails.
In-Reply-To: <20171128114943.dn4hpgxb6st3ng23@phenom.ffwll.local>
Message-ID: <alpine.LSU.2.20.1711281603210.10192@er-systems.de>
References: <alpine.LSU.2.20.1711281123060.17234@er-systems.de> <20171128111603.62757-1-maarten.lankhorst@linux.intel.com> <20171128114943.dn4hpgxb6st3ng23@phenom.ffwll.local>
User-Agent: Alpine 2.20 (LSU 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
X-Virus-Checker-Version: clamassassin 1.2.4 with clamdscan / ClamAV 0.99.2/24081/Tue Nov 28 10:07:12 2017 signatures .
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 28 Nov 2017, Daniel Vetter wrote:

> On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote:
>> Some drivers like i915 start with crtc's enabled, but with deferred
>> fbcon setup they were no longer disabled as part of fbdev setup.
>> Headless units could no longer enter pc3 state because the crtc was
>> still enabled.
>>
>> Fix this by calling restore_fbdev_mode when we would have called
>> it otherwise once during initial fbdev setup.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Fixes: ca91a2758fce ("drm/fb-helper: Support deferred setup")
>
> Please use dim fixes to get a more complete Cc: list for regression fixes.
>
>> Cc: <stable@vger.kernel.org> # v4.14+
>> Reported-by: Thomas Voegtle <tv@lio96.de>
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> But please confirm with the reporter that it indeed fixes the issue before
> pushing.
> -Daniel

I re-checked the latest version of the patch and it indeed fixes the 
problem.

Thanks,

    Thomas