From: Miroslav Benes <mbenes@suse.cz>
To: Petr Mladek <pmladek@suse.com>
Cc: jpoimboe@redhat.com, jikos@kernel.org,
Jason Baron <jbaron@akamai.com>,
jeyu@kernel.org, Evgenii Shatokhin <eshatokhin@virtuozzo.com>,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org
Subject: Re: PATCH v6 4/6] livepatch: Allow to unpatch only functions of the given type
Date: Wed, 31 Jan 2018 16:42:10 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.21.1801311639450.7649@pobox.suse.cz> (raw)
In-Reply-To: <20180125160203.28959-5-pmladek@suse.com>
> +void klp_unpatch_object(struct klp_object *obj, enum klp_func_type ftype)
> {
> struct klp_func *func;
> + bool patched = false;
>
> - klp_for_each_func(obj, func)
> - if (func->patched)
> + klp_for_each_func(obj, func) {
> + if (!func->patched)
> + continue;
> +
> + if (ftype == KLP_FUNC_ANY || ftype == func->ftype)
You defined klp_is_func_type() exactly for this purpose.
Otherwise, it looks good. There is no functional change.
Miroslav
next prev parent reply other threads:[~2018-01-31 15:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 16:01 PATCH v6 0/6] livepatch: Atomic replace feature Petr Mladek
2018-01-25 16:01 ` PATCH v6 1/6] livepatch: Use lists to manage patches, objects and functions Petr Mladek
2018-01-25 16:01 ` PATCH v6 2/6] livepatch: Free only structures with initialized kobject Petr Mladek
2018-02-01 14:25 ` Joe Lawrence
2018-01-25 16:02 ` PATCH v6 3/6] livepatch: Initial support for dynamic structures Petr Mladek
2018-01-31 15:39 ` Miroslav Benes
2018-02-05 10:33 ` Petr Mladek
2018-01-25 16:02 ` PATCH v6 4/6] livepatch: Allow to unpatch only functions of the given type Petr Mladek
2018-01-31 15:42 ` Miroslav Benes [this message]
2018-01-25 16:02 ` PATCH v6 5/6] livepatch: Support separate list for replaced patches Petr Mladek
2018-01-31 16:19 ` Miroslav Benes
2018-01-25 16:02 ` PATCH v6 6/6] livepatch: Add atomic replace Petr Mladek
2018-01-26 4:27 ` Jason Baron
2018-01-26 9:09 ` Petr Mladek
2018-01-26 10:33 ` Evgenii Shatokhin
2018-01-31 21:55 ` Josh Poimboeuf
2018-02-01 8:15 ` Evgenii Shatokhin
2018-02-01 13:49 ` Miroslav Benes
2018-02-05 14:15 ` Petr Mladek
2018-02-01 13:49 ` PATCH v6 0/6] livepatch: Atomic replace feature Miroslav Benes
2018-02-01 14:28 ` Joe Lawrence
2018-02-01 15:08 ` Miroslav Benes
2018-02-01 15:18 ` Josh Poimboeuf
2018-02-01 15:51 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.1801311639450.7649@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=eshatokhin@virtuozzo.com \
--cc=jbaron@akamai.com \
--cc=jeyu@kernel.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®