From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 335C1C43387 for ; Fri, 21 Dec 2018 09:45:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D1F52173C for ; Fri, 21 Dec 2018 09:45:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388460AbeLUJpx (ORCPT ); Fri, 21 Dec 2018 04:45:53 -0500 Received: from mx2.suse.de ([195.135.220.15]:41684 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1733247AbeLUJpw (ORCPT ); Fri, 21 Dec 2018 04:45:52 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8AAE5AE76; Fri, 21 Dec 2018 09:45:50 +0000 (UTC) Date: Fri, 21 Dec 2018 10:45:49 +0100 (CET) From: Miroslav Benes To: Josh Poimboeuf cc: Jiri Kosina , yamada.masahiro@socionext.com, michal.lkml@markovi.net, jeyu@kernel.org, pmladek@suse.com, linux-kbuild@vger.kernel.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Joao Moreira Subject: Re: [PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled In-Reply-To: <20181220144626.2uwuzsmdowbrmxxq@treble> Message-ID: References: <20181219141744.32392-1-mbenes@suse.cz> <20181219165428.5udrppedpdvf2u7k@treble> <20181219172127.o753af7pkrsttcgl@treble> <20181220144626.2uwuzsmdowbrmxxq@treble> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Dec 2018, Josh Poimboeuf wrote: > On Thu, Dec 20, 2018 at 09:33:05AM +0100, Miroslav Benes wrote: > > > > Though, upstream, almost everybody seems to use kpatch-build, for which > > > > this patch doesn't help. And people will continue to do so until we > > > > have decent source-based tooling. Will the klp-convert patches be > > > > revived soon? > > > > > > Let me add Joao, who's working on that. > > > > > > Joao, I think you had something basically ready for upstream exposure, > > > right? > > > > I think that when Joao posted it a long time ago, the conclusion was that > > it would be better to wait for the source-based tooling and have the > > complete solution. I may misremember though. > > > > If Josh thinks that it would be acceptable to have klp-convert merged even > > without the tooling, I'm all for it. > > > > We're about to start using it at SUSE and staying close to upstream would > > definitely be better. > > A complete toolchain should definitely be the end goal. > > But as a usable first step, only *some* of the tooling is required, > since some of the steps can be done manually, right? > > So starting out, for something usable, I believe the following would be > the bare minimum: > > * -flive-patching > > * The analysis tool which analyzes the -fdump-ipa-clones files > > * klp-convert > > * Documentation describing the end-to-end patch creation process, > including the manual steps and how to use the above tools > > Did I miss anything? > > Then over time we can fill in the gaps (manual steps) with automation. Agreed. Miroslav