From: Michael Matz <matz@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Borislav Petkov <bp@alien8.de>, x86-ml <x86@kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] asm/io: Correct output operand specification of the MMIO write* routines
Date: Thu, 18 Apr 2019 12:16:47 +0000 (UTC) [thread overview]
Message-ID: <alpine.LSU.2.21.1904181203170.8064@wotan.suse.de> (raw)
In-Reply-To: <CAHk-=wjazpzX=Y==69hfafDpcgcrwaNcZ-XdJnoVXX8+iy3zLA@mail.gmail.com>
Hi,
On Wed, 17 Apr 2019, Linus Torvalds wrote:
> So I see no upside to changing it.
As long as the memory clobber stays (and it can't be removed in the
general case, as you say) the change has no practical effect.
<outsider>
It does have a psychological upside, though: people won't continue to
wonder why the asm doesn't precisely specify what it does, and instead
only declares a memory-read while clearly being a memory write.
Normally, with asms, leaving nothing to wonder about is a good thing.
</outsider>
Ciao,
Michael.
prev parent reply other threads:[~2019-04-18 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 8:50 Borislav Petkov
2019-04-17 16:26 ` Linus Torvalds
2019-04-18 12:16 ` Michael Matz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.1904181203170.8064@wotan.suse.de \
--to=matz@suse.de \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®