From: Miroslav Benes <mbenes@suse.cz>
To: YueHaibing <yuehaibing@huawei.com>
Cc: jeyu@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/module: Fix memleak in module_add_modinfo_attrs()
Date: Wed, 8 Jan 2020 09:05:36 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.21.2001080905110.13391@pobox.suse.cz> (raw)
In-Reply-To: <20191228115455.24088-1-yuehaibing@huawei.com>
On Sat, 28 Dec 2019, YueHaibing wrote:
> In module_add_modinfo_attrs() if sysfs_create_file() fails
> on the first iteration of the loop (so i = 0), we forget to
> free the modinfo_attrs.
>
> Fixes: bc6f2a757d52 ("kernel/module: Fix mem leak in module_add_modinfo_attrs")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
M
next prev parent reply other threads:[~2020-01-08 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 11:54 YueHaibing
2020-01-08 8:05 ` Miroslav Benes [this message]
2020-01-08 16:24 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2001080905110.13391@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®