From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56948C4332D for ; Fri, 20 Mar 2020 16:20:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3498E20724 for ; Fri, 20 Mar 2020 16:20:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727805AbgCTQUu (ORCPT ); Fri, 20 Mar 2020 12:20:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:40720 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727754AbgCTQUt (ORCPT ); Fri, 20 Mar 2020 12:20:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C2132B13C; Fri, 20 Mar 2020 16:20:47 +0000 (UTC) Date: Fri, 20 Mar 2020 17:20:47 +0100 (CET) From: Miroslav Benes To: Peter Zijlstra cc: tglx@linutronix.de, jpoimboe@redhat.com, linux-kernel@vger.kernel.org, x86@kernel.org, mhiramat@kernel.org, brgerst@gmail.com Subject: Re: [PATCH v2 17/19] objtool: Optimize !vmlinux.o again In-Reply-To: <20200318132025.GH20730@hirez.programming.kicks-ass.net> Message-ID: References: <20200317170234.897520633@infradead.org> <20200317170910.819744197@infradead.org> <20200318132025.GH20730@hirez.programming.kicks-ass.net> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Mar 2020, Peter Zijlstra wrote: > On Tue, Mar 17, 2020 at 06:02:51PM +0100, Peter Zijlstra wrote: > > When doing kbuild tests to see if the objtool changes affected those I > > found that there was a measurable regression: > > > > pre post > > > > real 1m13.594 1m16.488s > > user 34m58.246s 35m23.947s > > sys 4m0.393s 4m27.312s > > > > Perf showed that for small files the increased hash-table sizes were a > > measurable difference. Since we already have -l "vmlinux" to > > distinguish between the modes, make it also use a smaller portion of > > the hash-tables. > > > > This flips it into a small win: > > > > real 1m14.143s > > user 34m49.292s > > sys 3m44.746s > > > > Signed-off-by: Peter Zijlstra (Intel) > > There was one 'elf_' prefixing gone missing. Updated patch below. I think there is one more missing in create_orc_entry(). Miroslav