From: Miroslav Benes <mbenes@suse.cz>
To: Peter Zijlstra <peterz@infradead.org>
Cc: tglx@linutronix.de, jpoimboe@redhat.com,
linux-kernel@vger.kernel.org, x86@kernel.org,
mhiramat@kernel.org, brgerst@gmail.com
Subject: Re: [PATCH v2 17/19] objtool: Optimize !vmlinux.o again
Date: Mon, 23 Mar 2020 08:27:22 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.21.2003230826570.23992@pobox.suse.cz> (raw)
In-Reply-To: <20200321161151.GB3323@worktop.programming.kicks-ass.net>
On Sat, 21 Mar 2020, Peter Zijlstra wrote:
> On Sat, Mar 21, 2020 at 04:14:21PM +0100, Peter Zijlstra wrote:
> > On Fri, Mar 20, 2020 at 05:20:47PM +0100, Miroslav Benes wrote:
> >
> > > I think there is one more missing in create_orc_entry().
> >
> > I'm thikning you're quite right about that.... lemme see what to do
> > about that.
>
> ---
> --- a/tools/objtool/elf.c
> +++ b/tools/objtool/elf.c
> @@ -472,6 +472,14 @@ static int read_symbols(struct elf *elf)
> return -1;
> }
>
> +void elf_add_rela(struct elf *elf, struct rela *rela)
> +{
> + struct section *sec = rela->sec;
> +
> + list_add_tail(&rela->list, &sec->rela_list);
> + elf_hash_add(elf->rela_hash, &rela->hash, rela_hash(rela));
> +}
> +
> static int read_relas(struct elf *elf)
> {
> struct section *sec;
> @@ -519,8 +527,7 @@ static int read_relas(struct elf *elf)
> return -1;
> }
>
> - list_add_tail(&rela->list, &sec->rela_list);
> - elf_hash_add(elf->rela_hash, &rela->hash, rela_hash(rela));
> + elf_add_rela(elf, rela);
> nr_rela++;
> }
> max_rela = max(max_rela, nr_rela);
> --- a/tools/objtool/elf.h
> +++ b/tools/objtool/elf.h
> @@ -127,6 +127,7 @@ struct section *elf_create_rela_section(
> int elf_rebuild_rela_section(struct section *sec);
> int elf_write(struct elf *elf);
> void elf_close(struct elf *elf);
> +void elf_add_rela(struct elf *elf, struct rela *rela);
>
> #define for_each_sec(file, sec) \
> list_for_each_entry(sec, &file->elf->sections, list)
> --- a/tools/objtool/orc_gen.c
> +++ b/tools/objtool/orc_gen.c
> @@ -111,8 +111,7 @@ static int create_orc_entry(struct elf *
> rela->offset = idx * sizeof(int);
> rela->sec = ip_relasec;
>
> - list_add_tail(&rela->list, &ip_relasec->rela_list);
> - hash_add(elf->rela_hash, &rela->hash, rela_hash(rela));
> + elf_add_rela(elf, rela);
>
> return 0;
> }
Yup, looks good.
Miroslav
next prev parent reply other threads:[~2020-03-23 7:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 17:02 [PATCH v2 00/19] objtool: vmlinux.o and noinstr validation Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 01/19] objtool: Introduce validate_return() Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 02/19] objtool: Rename func_for_each_insn() Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 03/19] objtool: Rename func_for_each_insn_all() Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 04/19] x86/kexec: Use RIP relative addressing Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 05/19] objtool: Optimize find_symbol_by_index() Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 06/19] objtool: Add a statistics mode Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 07/19] objtool: Optimize find_section_by_index() Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 08/19] objtool: Optimize find_section_by_name() Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 09/19] objtool: Optimize find_symbol_*() and read_symbols() Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 10/19] objtool: Rename find_containing_func() Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 11/19] objtool: Resize insn_hash Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 12/19] objtool: Optimize find_symbol_by_name() Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 13/19] objtool: Optimize read_sections() Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 14/19] objtool: Delete cleanup() Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 15/19] objtool: Optimize find_rela_by_dest_range() Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 16/19] objtool: Implement noinstr validation Peter Zijlstra
2020-03-17 21:00 ` Josh Poimboeuf
2020-03-18 9:03 ` Peter Zijlstra
2020-03-18 10:06 ` Peter Zijlstra
2020-03-18 13:21 ` Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 17/19] objtool: Optimize !vmlinux.o again Peter Zijlstra
2020-03-18 13:20 ` Peter Zijlstra
2020-03-20 16:20 ` Miroslav Benes
2020-03-21 15:14 ` Peter Zijlstra
2020-03-21 16:11 ` Peter Zijlstra
2020-03-23 7:27 ` Miroslav Benes [this message]
2020-03-17 17:02 ` [PATCH v2 18/19] objtool: Use sec_offset_hash() for insn_hash Peter Zijlstra
2020-03-17 17:02 ` [PATCH v2 19/19] objtool: Detect loading function pointers across noinstr Peter Zijlstra
2020-03-17 23:39 ` kbuild test robot
2020-03-17 23:43 ` Nick Desaulniers
2020-03-18 11:02 ` Peter Zijlstra
2020-03-18 7:18 ` kbuild test robot
2020-03-17 21:05 ` [PATCH v2 00/19] objtool: vmlinux.o and noinstr validation Josh Poimboeuf
2020-03-18 13:18 ` [RFC][PATCH v2 20/19] kbuild/objtool: Add objtool-vmlinux.o pass Peter Zijlstra
2020-03-18 14:13 ` Peter Zijlstra
2020-03-18 18:34 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2003230826570.23992@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=brgerst@gmail.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®