From: Miroslav Benes <mbenes@suse.cz>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
jeyu@kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
keescook@chromium.org
Subject: Re: [PATCH] module: Harden STRICT_MODULE_RWX
Date: Mon, 6 Apr 2020 11:55:39 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.21.2004061146590.26870@pobox.suse.cz> (raw)
In-Reply-To: <20200403165631.hrxxm3pnzqa4vxln@treble>
On Fri, 3 Apr 2020, Josh Poimboeuf wrote:
> On Fri, Apr 03, 2020 at 06:37:16PM +0200, Peter Zijlstra wrote:
> > +{
> > + int i;
> > +
> > + for (i = 0; i < hdr->e_shnum; i++) {
> > + if (sechdrs[i].sh_flags & (SHF_EXECINSTR|SHF_WRITE))
> > + return -ENOEXEC;
>
> I think you only want the error when both are set?
>
> if (sechdrs[i].sh_flags & (SHF_EXECINSTR|SHF_WRITE) == (SHF_EXECINSTR|SHF_WRITE))
A section with SHF_EXECINSTR and SHF_WRITE but without SHF_ALLOC would be
strange though, no? It wouldn't be copied to the final module later
anyway.
Looking at layout_sections()... a section with
SHF_EXECINSTR|SHF_WRITE|SHF_ALLOC would not be counted at all. However,
move_module() later copies everything with SHF_ALLOC flag to the final
module. If there is WXA section, there would be a bug because the
allocation there would not get the correct size. In that case it is
important to error out early as you're proposing.
Am I missing something?
Miroslav
next prev parent reply other threads:[~2020-04-06 9:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 16:37 Peter Zijlstra
2020-04-03 16:56 ` Josh Poimboeuf
2020-04-03 17:08 ` Peter Zijlstra
2020-04-06 9:55 ` Miroslav Benes [this message]
2020-04-06 10:46 ` Jessica Yu
2020-04-06 11:27 ` Peter Zijlstra
2020-04-06 12:53 ` Jessica Yu
2020-04-06 14:11 ` Peter Zijlstra
2020-04-07 7:43 ` Miroslav Benes
2020-04-09 16:55 ` Miroslav Benes
2020-04-10 9:04 ` Jessica Yu
2020-04-03 16:59 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2004061146590.26870@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=jeyu@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®