From: Miroslav Benes <mbenes@suse.cz>
To: Muchun Song <songmuchun@bytedance.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, x86@kernel.org, mingo@kernel.org,
peterz@infradead.org, shile.zhang@linux.alibaba.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/unwind: Make some variables static
Date: Tue, 14 Apr 2020 11:23:37 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.21.2004141123030.6508@pobox.suse.cz> (raw)
In-Reply-To: <20200413144727.51258-1-songmuchun@bytedance.com>
On Mon, 13 Apr 2020, Muchun Song wrote:
> The variables are local to the source and do not need to be
> in global scope, so make them static.
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
> arch/x86/kernel/unwind_orc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c
> index e9cc182aa97ee..0dbabc469ce2d 100644
> --- a/arch/x86/kernel/unwind_orc.c
> +++ b/arch/x86/kernel/unwind_orc.c
> @@ -16,11 +16,11 @@ extern struct orc_entry __start_orc_unwind[];
> extern struct orc_entry __stop_orc_unwind[];
>
> static DEFINE_MUTEX(sort_mutex);
> -int *cur_orc_ip_table = __start_orc_unwind_ip;
> -struct orc_entry *cur_orc_table = __start_orc_unwind;
> +static int *cur_orc_ip_table = __start_orc_unwind_ip;
> +static struct orc_entry *cur_orc_table = __start_orc_unwind;
>
> -unsigned int lookup_num_blocks;
> -bool orc_init;
> +static unsigned int lookup_num_blocks;
> +static bool orc_init;
>
> static inline unsigned long orc_ip(const int *ip)
> {
> --
Already fixed in
https://lore.kernel.org/lkml/63b5cab2e28b9c08854fc57f5b512a9ccf76ad95.1584033751.git.jpoimboe@redhat.com/
Thanks,
Miroslav
prev parent reply other threads:[~2020-04-14 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 14:47 Muchun Song
2020-04-14 9:23 ` Miroslav Benes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2004141123030.6508@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shile.zhang@linux.alibaba.com \
--cc=songmuchun@bytedance.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®