From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6255AC433DF for ; Tue, 9 Jun 2020 09:44:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44BDA20812 for ; Tue, 9 Jun 2020 09:44:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728552AbgFIJoQ (ORCPT ); Tue, 9 Jun 2020 05:44:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:53544 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726964AbgFIJoN (ORCPT ); Tue, 9 Jun 2020 05:44:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BEF78AD4A; Tue, 9 Jun 2020 09:44:15 +0000 (UTC) Date: Tue, 9 Jun 2020 11:44:11 +0200 (CEST) From: Miroslav Benes To: Julien Thierry cc: linux-kernel@vger.kernel.org, jpoimboe@redhat.com, peterz@infradead.org, mhelsley@vmware.com Subject: Re: [PATCH v2 0/4] Remove dependency of check subcmd upon orc In-Reply-To: <20200608071203.4055-1-jthierry@redhat.com> Message-ID: References: <20200608071203.4055-1-jthierry@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 Jun 2020, Julien Thierry wrote: > Hi, > > Matt Helsley's change[1] provided a base framework to opt-in/out > objtool subcommands at compile time. This makes it easier for > architectures to port objtool, one subcommand at a time. > > Orc generation relies on the check operation implementation. However, > the way this is done causes the check implementation to depend on the > implementation of orc generation functions to call if orc generation is > requested. This means that in order to implement check subcmd, orc > subcmd also need to be implemented. > > These patches aim at removing that dependency, having orc subcmd > being built on top of the check subcmd. > > Changes since v1 [2]: > - Remove redundant check in create_orc pointed out by Miroslav > > [1] https://www.spinics.net/lists/kernel/msg3510844.html > [2] https://lkml.org/lkml/2020/6/4/675 Reviewed-by: Miroslav Benes M