From: Miroslav Benes <mbenes@suse.cz>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
clang-built-linux@googlegroups.com,
Arnd Bergmann <arnd@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH] objtool: Fix seg fault with Clang non-section symbols
Date: Wed, 16 Dec 2020 13:48:18 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.21.2012161347400.24446@pobox.suse.cz> (raw)
In-Reply-To: <ba6b6c0f0dd5acbba66e403955a967d9fdd1726a.1607983452.git.jpoimboe@redhat.com>
On Mon, 14 Dec 2020, Josh Poimboeuf wrote:
> The Clang assembler likes to strip section symbols, which means objtool
> can't reference some text code by its section. This confuses objtool
> greatly, causing it to seg fault.
>
> The fix is similar to what was done before, for ORC reloc generation:
>
> e81e07244325 ("objtool: Support Clang non-section symbols in ORC generation")
>
> Factor out that code into a common helper and use it for static call
> reloc generation as well.
>
> Reported-by: Arnd Bergmann <arnd@kernel.org>
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1207
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
M
next prev parent reply other threads:[~2020-12-16 12:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 22:04 Josh Poimboeuf
2020-12-16 12:48 ` Miroslav Benes [this message]
2020-12-16 13:49 ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2021-02-11 13:32 ` Xi Ruoyao
2021-02-11 13:55 ` Greg Kroah-Hartman
2021-02-11 18:46 ` Nick Desaulniers
2021-02-12 9:40 ` Xi Ruoyao
2021-02-12 15:30 ` Greg Kroah-Hartman
2021-02-12 17:07 ` Josh Poimboeuf
2021-02-12 17:45 ` Steven Rostedt
2021-02-13 14:09 ` Greg Kroah-Hartman
2021-02-13 14:13 ` Steven Rostedt
2021-02-13 15:52 ` Josh Poimboeuf
2021-02-13 16:25 ` Greg Kroah-Hartman
2021-02-14 15:51 ` Josh Poimboeuf
2021-02-15 14:53 ` Steven Rostedt
2021-02-15 15:58 ` Josh Poimboeuf
2021-02-15 21:22 ` Steven Rostedt
2021-02-13 13:00 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2012161347400.24446@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=arnd@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®