From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3492C433DB for ; Fri, 15 Jan 2021 11:40:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 777542313E for ; Fri, 15 Jan 2021 11:40:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727911AbhAOLke (ORCPT ); Fri, 15 Jan 2021 06:40:34 -0500 Received: from mx2.suse.de ([195.135.220.15]:40246 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726918AbhAOLke (ORCPT ); Fri, 15 Jan 2021 06:40:34 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CE253ACB0; Fri, 15 Jan 2021 11:39:52 +0000 (UTC) Date: Fri, 15 Jan 2021 12:39:52 +0100 (CET) From: Miroslav Benes To: Josh Poimboeuf cc: x86@kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Borislav Petkov , Julien Thierry , Nick Desaulniers Subject: Re: [PATCH] objtool: Don't fail the kernel build on fatal errors In-Reply-To: <9ec7a9531e99f461e02adc18a4124c921c0ab777.1610664286.git.jpoimboe@redhat.com> Message-ID: References: <9ec7a9531e99f461e02adc18a4124c921c0ab777.1610664286.git.jpoimboe@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jan 2021, Josh Poimboeuf wrote: > This is basically a revert of commit 644592d32837 ("objtool: Fail the > kernel build on fatal errors"). > > That change turned out to be more trouble than it's worth. Failing the > build is an extreme measure which sometimes gets too much attention and > blocks CI build testing. > > These fatal-type warnings aren't yet as rare as we'd hope, due to the > ever-increasing matrix of supported toolchains/plugins and their > fast-changing nature as of late. > > Also, there are more people (and bots) looking for objtool warnings than > ever before, so such warnings not likely to be ignored for long. > > Suggested-by: Nick Desaulniers > Signed-off-by: Josh Poimboeuf Reviewed-by: Miroslav Benes M