From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47784C433DB for ; Fri, 26 Mar 2021 08:40:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3CA161A45 for ; Fri, 26 Mar 2021 08:40:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230007AbhCZIjf (ORCPT ); Fri, 26 Mar 2021 04:39:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:52876 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229871AbhCZIjN (ORCPT ); Fri, 26 Mar 2021 04:39:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5F4E1AA55; Fri, 26 Mar 2021 08:39:12 +0000 (UTC) Date: Fri, 26 Mar 2021 09:39:12 +0100 (CET) From: Miroslav Benes To: Jens Axboe cc: Joe Lawrence , Dong Kai , jpoimboe@redhat.com, jikos@kernel.org, pmladek@suse.com, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] livepatch: klp_send_signal should treat PF_IO_WORKER like PF_KTHREAD In-Reply-To: Message-ID: References: <20210325014836.40649-1-dongkai11@huawei.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Mar 2021, Jens Axboe wrote: > On 3/25/21 3:30 AM, Miroslav Benes wrote: > >> (PF_KTHREAD | PF_IO_WORKER) is open coded in soo many places maybe this is a > >> silly question, but... > >> > >> If the livepatch code could use fake_signal_wake_up(), we could consolidate > >> the pattern in klp_send_signals() with the one in freeze_task(). Then there > >> would only one place for wake up / fake signal logic. > >> > >> I don't fully understand the differences in the freeze_task() version, so I > >> only pose this as a question and not v2 request. > > > > The plan was to remove our live patching fake signal completely and use > > the new infrastructure Jens proposed in the past. > > That would be great, I've actually been waiting for that to show up! Sorry about that. I failed to notice that the infrastructure was merged already. I'll send it soonish. > I would greatly prefer this approach if you deem it suitable for 5.12, > if not we'll still need the temporary work-around for live patching. I noticed there is 20210326003928.978750-1-axboe@kernel.dk now, so I suppose we should wait for that to land in mainline and simply do nothing about PF_IO_WORKER for live patching. Miroslav