From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F533C43461 for ; Thu, 20 May 2021 14:41:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D4D4613BE for ; Thu, 20 May 2021 14:41:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242538AbhETOmf (ORCPT ); Thu, 20 May 2021 10:42:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:54974 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240620AbhETOlG (ORCPT ); Thu, 20 May 2021 10:41:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 20BE0ABC2; Thu, 20 May 2021 14:39:44 +0000 (UTC) Date: Thu, 20 May 2021 16:39:43 +0200 (CEST) From: Miroslav Benes To: Jon Mediero cc: Jessica Yu , Petr Mladek , linux-kernel@vger.kernel.org Subject: Re: [PATCH] module: correctly exit module_kallsyms_on_each_symbol when fn() != 0 In-Reply-To: <20210520122326.18563-1-jmdr@disroot.org> Message-ID: References: <20210520122326.18563-1-jmdr@disroot.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 May 2021, Jon Mediero wrote: > Commit 013c1667cf78 ("kallsyms: refactor > {,module_}kallsyms_on_each_symbol") replaced the return inside the > nested loop with a break, changing the semantics of the function: the > break only exits the innermost loop, so the code continues iterating the > symbols of the next module instead of exiting. > > Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol") > Signed-off-by: Jon Mediero Reviewed-by: Miroslav Benes M