From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E576C433F5 for ; Wed, 9 Mar 2022 08:58:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231623AbiCII7q (ORCPT ); Wed, 9 Mar 2022 03:59:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230490AbiCII7o (ORCPT ); Wed, 9 Mar 2022 03:59:44 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D4533CFC1 for ; Wed, 9 Mar 2022 00:58:46 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id CF83A210FF; Wed, 9 Mar 2022 08:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1646816324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q4AJu/wysJHmIswvQXSaX+yqN3X7O/Pe+3NXzpiDTA8=; b=Y0Fzdvy7p16kKlow8GqWKUk8k/nyRyZ4G2StnJyAv0PV0SYyA5cAV+wuyOxewuQWZu/eij p8li1z/HvoPnTA8SzB9OxKeViJH+3SgKCl3GBzTtC52A4mWT4WNZ+BNYNeIFNw2RqwMEZ0 5uBFcBsJ8oaqfx7eP/kzghnysfrji30= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1646816324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q4AJu/wysJHmIswvQXSaX+yqN3X7O/Pe+3NXzpiDTA8=; b=mypzG7T8IMXnyC0Gytkq2D053hqMmCQGhUOWuF19SI2gnqtnE61vtEDcSYEtD6VxYmf5NQ N3ro8Qpfoqp+gSBg== Received: from pobox.suse.cz (pobox.suse.cz [10.100.2.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 409EAA3B84; Wed, 9 Mar 2022 08:58:44 +0000 (UTC) Date: Wed, 9 Mar 2022 09:58:44 +0100 (CET) From: Miroslav Benes To: Peter Zijlstra cc: x86@kernel.org, joao@overdrivepizza.com, hjl.tools@gmail.com, jpoimboe@redhat.com, andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org, ndesaulniers@google.com, keescook@chromium.org, samitolvanen@google.com, mark.rutland@arm.com, alyssa.milburn@intel.com, rostedt@goodmis.org, mhiramat@kernel.org, alexei.starovoitov@gmail.com Subject: Re: [PATCH v4 19/45] x86/livepatch: Validate __fentry__ location In-Reply-To: <20220308154318.285971256@infradead.org> Message-ID: References: <20220308153011.021123062@infradead.org> <20220308154318.285971256@infradead.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Mar 2022, Peter Zijlstra wrote: > Currently livepatch assumes __fentry__ lives at func+0, which is most > likely untrue with IBT on. Instead make it use ftrace_location() by > default which both validates and finds the actual ip if there is any > in the same symbol. > > Suggested-by: Josh Poimboeuf > Signed-off-by: Peter Zijlstra (Intel) Acked-by: Miroslav Benes M