From: Miroslav Benes <mbenes@suse.cz>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Petr Mladek <pmladek@suse.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
mingo@kernel.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, jpoimboe@kernel.org, jikos@kernel.org,
joe.lawrence@redhat.com, linux-kernel@vger.kernel.org,
live-patching@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [RFC][PATCH] sched,livepatch: Untangle cond_resched() and live-patching
Date: Wed, 26 Mar 2025 15:52:32 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.21.2503261547000.4152@pobox.suse.cz> (raw)
In-Reply-To: <20250326144212.GG25239@noisy.programming.kicks-ass.net>
On Wed, 26 Mar 2025, Peter Zijlstra wrote:
> On Wed, Mar 26, 2025 at 03:37:50PM +0100, Miroslav Benes wrote:
>
> > If I remember correctly, we had something like this in the old kGraft
> > implementation of the live patching (SUSE way). We exactly had a hook
> > somewhere in the kthread freezing code. This looks much cleaner and as far
> > as I know the fridge went through improvements recently.
>
> Yeah, I rewrote it a while ago :-)
Right :)
> > Peter, so that I understand it correctly... we would rely on all kthreads
> > becoming freezable eventually so that both suspend and livepatch benefit.
> > Is that what you meant by the above?
>
> Well, IIRC (its been a while already) all kthreads should have a
> FREEZABLE already. Things like suspend-to-idle don't hit the hotplug
> path at all anymore and everything must freeze, otherwise they fail.
Good.
> I was more meaning the time-to-freeze; if some kthreads take a long time
> to freeze/patch then this would want improving on both ends.
Makes sense.
So I am all for the patch. See my comment elsewhere though.
Miroslav
next prev parent reply other threads:[~2025-03-26 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 13:49 Peter Zijlstra
2025-03-26 9:49 ` Petr Mladek
2025-03-26 10:38 ` Peter Zijlstra
2025-03-26 14:37 ` Miroslav Benes
2025-03-26 14:42 ` Peter Zijlstra
2025-03-26 14:52 ` Miroslav Benes [this message]
2025-03-26 14:54 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2503261547000.4152@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=bigeasy@linutronix.de \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®