mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miroslav Benes <mbenes@suse.cz>
To: Dmitry Malkin <dma@nebius.com>
Cc: "live-patching@vger.kernel.org" <live-patching@vger.kernel.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	 NB-Core Team <NB-CoreTeam@nebius.com>
Subject: Re: [PATCH] klp-build: Add an option to set the livepatch module version
Date: Wed, 30 Sep 2026 13:36:15 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LSU.2.21.2609301334470.17217@pobox.suse.cz> (raw)
In-Reply-To: <AM9P190MB1666E0A06E9F75E93BF960C9DB8B2@AM9P190MB1666.EURP190.PROD.OUTLOOK.COM>

On Wed, 30 Sep 2026, Dmitry Malkin wrote:

> Livepatch modules generated by klp-build do not contain MODULE_VERSION
> metadata. Add --module-version to identify a livepatch release
> independently of its module name.
> 
> Append MODULE_VERSION() to the temporary copy of init.c when the option
> is supplied. Restrict the accepted characters so the value can be
> embedded safely in a C string literal. Leave the source template and
> default build behavior unchanged.
> 
> For example:
> 
> $ scripts/livepatch/klp-build --module-version=1.2.3 fix.patch
> 
> The version can be read from the resulting module file without loading it:
> 
> $ modinfo -F version livepatch-fix.ko
> 
> The version is descriptive module metadata; it does not control
> livepatch replacement or compatibility.
> 
> Signed-off-by: Dmitry Malkin <dma@nebius.com>

thank you for the patch but MODULE_VERSION() is being removed from the 
kernel [1]. build-id should be sufficient.

Miroslav

[1] https://lore.kernel.org/lkml/20260731-module_ver_remove-v2-0-c9163858f382@linuxfoundation.org/

      reply	other threads:[~2026-09-30 11:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30  9:23 Dmitry Malkin
2026-09-30 11:36 ` Miroslav Benes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.21.2609301334470.17217@pobox.suse.cz \
    --to=mbenes@suse.cz \
    --cc=NB-CoreTeam@nebius.com \
    --cc=dma@nebius.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®