mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chad Dupuis <chad.dupuis@qlogic.com>
To: Masanari Iida <standby24x7@gmail.com>
Cc: <QLogic-Storage-Upstream@qlogic.com>, <JBottomley@parallels.com>,
	<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [SCSI] bnx2fc: Fix debug messasges in bnx2fc_io.c
Date: Mon, 13 Apr 2015 16:15:05 -0400	[thread overview]
Message-ID: <alpine.OSX.2.00.1504131614140.2118@administrators-macbook-pro.local> (raw)
In-Reply-To: <1428847633-30232-1-git-send-email-standby24x7@gmail.com>

Looks ok.

Acked-by: Chad Dupuis <chad.dupuis@qlogic.com>

On Sun, 12 Apr 2015, Masanari Iida wrote:

> The debug messages in bnx2fc_process_seq_cleanup_compl() doesn't
> match its function name.
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
> drivers/scsi/bnx2fc/bnx2fc_io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c
> index 9ecca85..1b53a68 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_io.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
> @@ -1319,7 +1319,7 @@ void bnx2fc_process_seq_cleanup_compl(struct bnx2fc_cmd *seq_clnp_req,
> 	int rc = 0;
> 	struct bnx2fc_rport *tgt = orig_io_req->tgt;
>
> -	BNX2FC_IO_DBG(orig_io_req, "Entered process_cleanup_compl xid = 0x%x"
> +	BNX2FC_IO_DBG(orig_io_req, "Entered process_seq_cleanup_compl xid = 0x%x"
> 			      "cmd_type = %d\n",
> 		   seq_clnp_req->xid, seq_clnp_req->cmd_type);
>
> @@ -1334,7 +1334,7 @@ void bnx2fc_process_seq_cleanup_compl(struct bnx2fc_cmd *seq_clnp_req,
> 	spin_lock_bh(&tgt->tgt_lock);
>
> 	if (rc)
> -		printk(KERN_ERR PFX "clnup_compl: Unable to send SRR"
> +		printk(KERN_ERR PFX "process_seq_clenup_compl: Unable to send SRR"
> 			" IO will abort\n");
> 	seq_clnp_req->cb_arg = NULL;
> 	kref_put(&orig_io_req->refcount, bnx2fc_cmd_release);
>

      reply	other threads:[~2015-04-13 20:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-12 14:07 Masanari Iida
2015-04-13 20:15 ` Chad Dupuis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.OSX.2.00.1504131614140.2118@administrators-macbook-pro.local \
    --to=chad.dupuis@qlogic.com \
    --cc=JBottomley@parallels.com \
    --cc=QLogic-Storage-Upstream@qlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=standby24x7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®