From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941552AbcIHPXw (ORCPT ); Thu, 8 Sep 2016 11:23:52 -0400 Received: from mail-by2nam01on0094.outbound.protection.outlook.com ([104.47.34.94]:50976 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S941159AbcIHPXt (ORCPT ); Thu, 8 Sep 2016 11:23:49 -0400 X-Greylist: delayed 1998 seconds by postgrey-1.27 at vger.kernel.org; Thu, 08 Sep 2016 11:23:49 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=chad.dupuis@qlogic.com; Date: Thu, 8 Sep 2016 10:50:03 -0400 From: Chad Dupuis X-X-Sender: cdupuis@administrators-macbook-pro.local To: Christophe JAILLET CC: , , , , , , Subject: Re: [PATCH] bnx2fc: Simplify code In-Reply-To: <1472886348-29813-1-git-send-email-christophe.jaillet@wanadoo.fr> Message-ID: References: <1472886348-29813-1-git-send-email-christophe.jaillet@wanadoo.fr> User-Agent: Alpine 2.00 (OSX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: CY1PR21CA0067.namprd21.prod.outlook.com (10.163.250.163) To CY4PR11MB1463.namprd11.prod.outlook.com (10.172.69.146) X-MS-Office365-Filtering-Correlation-Id: f02f83c1-2c1d-41b6-c8aa-08d3d7f7774e X-Microsoft-Exchange-Diagnostics: 1;CY4PR11MB1463;2:WTfLmDJWjCWOjJp3AHk1DWzqR0PeUReiMlOSfNwUFTWRFgoS/uH5n+QXyfb7RFVNPtySvn1y6uS33SrGtbWWfU0YkHtBJiGU10yWgIUW14VEcAPF1OUuBAeYMKLplSsdiScDTF+94WnX3VYhkM9hd98gf6J43+UxEsjmlxCS4DnZv+2lNnAHZ6DQfPEqMsEK;3:5/Py/XRRrdWxaJgyx6oD2Sb4xV4/eWP+rOMUNbUbFwnHeS232ee6svQ8zCtbc3nJYiUS01Dajol7P9hoWZhnUvJZTwd8eKvws4cigKS4qLRwIFIZnv/diCPkn6uMkvri X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR11MB1463; X-Microsoft-Exchange-Diagnostics: 1;CY4PR11MB1463;25:2W9703kIYZgDXbaKPPylCfIoeE1bQoN4Dfq7Rh6MoKVVIeofN4MyQwgK4zTdCzEcv6qY41O/WXr50SUg1ECIllOr728fN4r578nbkpY5H1jX5ykrwIOgiSujIrVXNxY8IKBd0tTKhBHIvxN77G08hR82cdp5IDZmprD4hZXpzZcB190L4Pw8vYhkM8jUDilvTqr/k27leFTxwWor8QuDt1sGWhVcVBspuMoYFg+LK7fSRhgOw7kA2TqeJubCJ2NMxM7dI98fOvQRx8mtaQN2lMlfrsaDrssyVQ8zlQPeLZPBfpM9GGSYq6nt4l0MzT500FryuLCj/KiZRfDmFtvo/tga0mi2z1q6oaBgdxViH5cyUXUNny7MBoE4FvW0M1ta3aq0BgqM5pA3Uen3lSFGZwXqjPgvrYtLL2dnEiqIYkkLW/DfanxZG1TxQ7YC49c9cMrpw63JdFmIQgfXsyVikXXpFfOtL7bT/iZ4bNx0rZZjPn9kgdKfMi1FmHmrftfpcE1Bddj4glsB9MrNiwH92p2E3MKsPIkxuGk3GLvmDH5onOtb73dgRxMaFLPyhV5LErpVrEETV4T2OCSR/SGCSf+5OQfSAhmunqKIbgJ0EqTI3GbtKNFsV9qAEaOxBmTxuf871mvESw/yUdOwlcbYnbQ2gAfmZiHF3Vq2Twj+odEqmvyGdlINZq9bEVrFqz3m;31:SFNaVW7evI0qGNoYnlKs4jGE8/9qr4LQCDJItWJ7te97qtVzIvtS80hHl1HUfZb9KVH7nYA5TPf4yeIgV2cMwR5w4VW3AUfBHUSYuBX3KHGcVsiKaE/TXSUuMroP1pgfe2Jiw9Ob4x5FW6ktBT4bx6NOSa8QyoqmNxbPuXcgD6idqpvMKPMGM6Re4WEcjJvnwpBRLUhHZc6iwWn7zlsqiUVeHdJDmgxxrh4+JYbjG54= X-LD-Processed: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;CY4PR11MB1463;20:gB4vPyinfmT9M8DCRMJGIxgMsBJfpM9otLyTvh6vBdhTD/1WG0zNbI889fAqkrBHYwasldb7zKposUm/H2sWzH3mhNM8dplJG0/u8L9xrDjj+9V5+i38SjmtdobjVfRxTg4M4minfy+L8i+jbJtlW6bkrI9UuoDQgBv6hIQYpsc=;4:B0WAuL0hhkcOr9HVpRMyjwRlbjBb4zKEVObxyXZ8e4lZbXWIaFvZU1l6pSVvd8/rgVHbVL68NCAGqOFw9zihMeiNoH1CDbR/ozbldMncIrRCAl49yQv7LmLUlfStqovJ9vAoEJAja5Ri4tlf2U7lx+pj0yVDvm0IQo1Ov8lQD4JkWRm7rXrawHrD+Y7hF+z0+teW8ref83Xi9JR+3CQ4rljkkiJhGv77GVg5zlaG5nt/VK1zVKj8WR0kHhMvSagTf7hlJpEesg0FyQxF4YyhUopqDyD0CCjesT3oXa0zM5AmgqXFjVQhQuwqT/19aUfmc2jXpNt3u8HUkdArGlqBrIyNqHGZNPciBuhj5TPkGDxwRxQv5utQvo9WPUrXgXgV11z3B+aHury4I59sNaGVgwtG0uQsuwM0mVGEGxk+cVd1XwRIdKbHinpKOwVij/ZU X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(155761271638844); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:CY4PR11MB1463;BCL:0;PCL:0;RULEID:;SRVR:CY4PR11MB1463; X-Forefront-PRVS: 00594E8DBA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(189002)(199003)(24454002)(92566002)(6116002)(5660300001)(23726003)(68736007)(66066001)(54356999)(3846002)(101416001)(110136002)(586003)(4001350100001)(83506001)(19580395003)(98436002)(47776003)(9686002)(97736004)(50986999)(76176999)(2906002)(106356001)(105586002)(4326007)(19580405001)(7846002)(42186005)(53416004)(81166006)(7736002)(2950100001)(46406003)(69596002)(8676002)(305945005)(50466002)(189998001)(86362001)(81156014)(77096005);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR11MB1463;H:n6018njbmq2l32.qlogic.org;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY4PR11MB1463;23:re8k/8vRZ0BucejH8JDLqc9psJw6wzv5VfGpH5sMr?= =?us-ascii?Q?zI7XfgnucI6Lah/UcknRA0vPZ8xDQoRE+p95Uo+VMERdy3i+G2ZgMTqR6Zoj?= =?us-ascii?Q?w7Zcs9gnDlwxQT/Ony5nv7P3LEXoPQ19RBFZi+9Sq75AHNAOkjGLA7+BY8/j?= =?us-ascii?Q?OyvMEgm2abFEUyZMHPhLQEWocGGzZBcEfYfuIWLjpYGZJIfhkx4QhFMA61eo?= =?us-ascii?Q?ubTeskLJ9tizAFns4g5FZU23zAqHk0FTQp9tKKOq4I5dIoQ1fhOuJXz3QUqM?= =?us-ascii?Q?VtCCu2Zuy4hRdRpYG6xG+uYX88bzEMyLWVtlRN6Ii2iTy5qiQbdoWYJ4vNZC?= =?us-ascii?Q?xLSzcnPtxuv6eHNLUvLnFDa5ojz0r9TnJlbSJhr3HTLkyOz0dYzluoLBm9DU?= =?us-ascii?Q?STHmU2p6Mj9R7n4Jts8fPhOTEk6SJJVuJ0fIExZOlNrEYZ0//IJdJVGbUwAJ?= =?us-ascii?Q?pB9GCe29brLPAgD1iX1bhoZucAAgEJ0Leq1NnQjscWIfk4IPc/Y3+s0t9kv0?= =?us-ascii?Q?1rjyHMwsGxCbuI/pD1wk5B2jhmTwaGwmebbIufg2h1C/FCLQvFSQ45soIzYG?= =?us-ascii?Q?W/MkMJmfcqFbyKc0aA5DVcAa34Rs4rWz4p6PlPdUoxUsyW7Vo3HPM01wKt+j?= =?us-ascii?Q?ANxIQLtFs8d/p1Wkr7IYy+7bBX6xCaAcN8LQE+zmDDyLZV/nN89mZUjaqx94?= =?us-ascii?Q?gvvhlSgUwYa7i88lnz8s8Q8laGOjwekEcwZlS3MqmF8TYeiwxk3ziE5sf337?= =?us-ascii?Q?QV/4PUUiGonviDfgmaxj6NJFd4h6opm9lKpcdI9uiK5N4tTbbRNWKiq8WZzR?= =?us-ascii?Q?cgJWVweDx4pVo/eNu/L9Z0uZJz10kUZ8wk4S54k5c3+K1FUDAG1+fFBVcyzN?= =?us-ascii?Q?mJuuZeWgzIXPV/5LlFLpfrV26IW8AdOr47L098vr543tq4wsmKqP1ZDye9xd?= =?us-ascii?Q?S/8B/tGzBUETiQsTRVAlxz2NJuv6tGsKXEntA/IkM/ky/8C/QKMF6dKBUTiL?= =?us-ascii?Q?aIjW65wleLGCs981yIPIFHJG6Idiir/EWZKMs6vIxoO8m2AA+0ZEKahYYZIr?= =?us-ascii?Q?d1PIUDqu3N1oQVFoXaJTp6PcPNPhGIs727L1KuPgfx/uQoHVNDo1snmQ3+Dk?= =?us-ascii?Q?0524gYcF2SZazZX9kY8CdchAepRAvPdLGIradXSoaHdRF9wDwcUJg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR11MB1463;6:b1vzBguBR9BwO7yZpFHM3ZmEtJOWF2/gu2NE1Z+XY50W0YmwFOi7h8Mzsj+sUU/CY/13X9QS3DCEr5zGZAMjZWHcmKvf1Ifp5WUy96c19Ldg3HxJl2XlvgaB3RenVUmvg5OMfOX+8lowkLoGXkr2NGkW52zRepYOIxy+Jo93F6NF/2SfHqV3GrtgTP5MFtJw2KqkLsa2avO1K6h2LXgVJuZRj/hMaMjhVhvdrPbcpGmiOZ5jRMfahI7osRzFJL1XXLeu0XVkj4oh+cPUXNqGKA6Uh6QZlxTvDH8UBJq5QjY=;5:xbOiMGeMJzj2mgAZJxDvriIvdXS9ZljslfUbQBnkkkmreTWFTqs5jvhCyCkf49HvKCCvDiqvARzvOgDuj2XGaFE1RE96rVmSJWOy923HxqSMgjOdjxXbU6wQztxOotZ8iShMq1NbZ0e6ntm4N4E1aQ==;24:4p9BjbcVV6s5m/yzdHhsrRxh6XsvHMiQOytcOeotEUbogTeQ5gvACApNmtt+Cl+qApDTJTndjfDNgsGij5oM/SKiI/lBcW4Cljkppn68jkQ=;7:pJPeDkrZkoSmWUQar+iPV9pbZLHdPxwFTHmFOyp5eq1ZXAbODA7DOqgLkSnNqjo6mDSNrnQfo4UZjT9+fGSb+N2BaM2QIDMzMCkn37BxhWFZL65lo9+BryLDll9VIum/yEMTqgUXrQ7GQpUpS6Bp9CmO/1RCHxdDQfUsRu5G23sjiBJMZ1p8TKOMsopMtaqFJtlfZk/6vmX2Xwohn35bYVWDnTdJBmHF1e4oi4KQ/dw30mDhFWHMH1TOj/wgyxRx SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: qlogic.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2016 14:50:23.2674 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1463 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 3 Sep 2016, 7:05am -0000, Christophe JAILLET wrote: > Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to > 'list_splice_init'. > > This has been spotted with the following coccinelle script: > ///// > @@ > expression y,z; > @@ > > - list_splice(y,z); > - INIT_LIST_HEAD(y); > + list_splice_init(y,z); > > Signed-off-by: Christophe JAILLET > --- > drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c > index a5052dd8d7e6..88be12a02764 100644 > --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c > +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c > @@ -2765,8 +2765,7 @@ static void __exit bnx2fc_mod_exit(void) > * held. > */ > mutex_lock(&bnx2fc_dev_lock); > - list_splice(&adapter_list, &to_be_deleted); > - INIT_LIST_HEAD(&adapter_list); > + list_splice_init(&adapter_list, &to_be_deleted); > adapter_count = 0; > mutex_unlock(&bnx2fc_dev_lock); > > Looks ok to me. Acked-by: Chad Dupuis