From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965253AbcIHPHL (ORCPT ); Thu, 8 Sep 2016 11:07:11 -0400 Received: from mail-by2nam01on0102.outbound.protection.outlook.com ([104.47.34.102]:26487 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S938686AbcIHPHJ (ORCPT ); Thu, 8 Sep 2016 11:07:09 -0400 X-Greylist: delayed 999 seconds by postgrey-1.27 at vger.kernel.org; Thu, 08 Sep 2016 11:07:09 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=chad.dupuis@qlogic.com; Date: Thu, 8 Sep 2016 10:51:05 -0400 From: Chad Dupuis X-X-Sender: cdupuis@administrators-macbook-pro.local To: Baoyou Xie CC: , , , , , , , Subject: Re: [PATCH] [SCSI] bnx2fc: mark symbols static where possible In-Reply-To: <1472971941-4882-1-git-send-email-baoyou.xie@linaro.org> Message-ID: References: <1472971941-4882-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Alpine 2.00 (OSX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: SN1PR10CA0065.namprd10.prod.outlook.com (10.164.10.161) To DM5PR11MB1466.namprd11.prod.outlook.com (10.172.36.137) X-MS-Office365-Filtering-Correlation-Id: a7d68539-8120-492d-4e01-08d3d7f7972d X-Microsoft-Exchange-Diagnostics: 1;DM5PR11MB1466;2:C5lTvXX9fo4o/sl3UYUDo7lWynPW/wHfcjC10UcmI5C9jvcDrblTdnaabV7Y9FETIQRHqVinsDA6SWKz4IC5NcTJ3WhylVkR+QviAxnYjV4BxqiwfSBT7mJ/y21TA6cBwmEDKOyjejsFgUEWtId1nQiy3pcBUewpyKBSY0ZF6GOrCq7bEMHASZKpyXhNn8RR;3:dfH+2d6kTI3ONZ2zSRnmk1iaw5Hatq6cgPSnhljVQPDq+WgWjRKTL5upU3eVfAWClP4arUC3DgW7DeolClGM6O5eVF+1eHAYNrKVL+0n3tPW6iOdi1GIHUpg1agujjyW;25:fJer+zq2yE3ByzQtcU9H9m/w9a9kKBDPJXxcEF2q/l0KhizWo4c9POJld9o0Y4WsOEQkeBXMm8PZdgIbgcCVOHT1MQcb/s3y/sONDF33ReMRC4GsCCs3pdUVthdihaZa7wPYiOjNbXro8nRjRy3gZy7C8uPhTgsUxoHkwAHvhbTyPjONTjTXOvCVu1NVHAaBSY9SqKlYo/hqJCjcndDMCnEvYRagtmvz5YtfQxnPoytToWADjzxcmMUSUKza4dzMPrv5y9JBurAQfWcd7HiQVjw8jcwJEOLmxf3jxKYCq89vvN5+Y9juQrXauXvYw84eR9jicApHP6dnJ6z0wA6Tfaq2paPVIpKxrJaMRfBfYf5c4DToaZEd6xFWWcGVBtBDgNuSXxnoo5ToSVbnq95yGg==;31:eefqumBzVEcXpS73dR+reY/C9nc7O0n4hlmsgNF41200u2hQDoQ6gwbajjbI5mUn8RQLX0tawkpQY7dPQj20LORs3j/m00A82ur8knQGbYdRPTM0KrftKJtECw++CG9taFSghAtMGehnts5Ro0NcjVYsbCSgifjptXY10i+/etpCCJFWAFVJFvPa2lY68uCvWExdovL3HwvipjAOV3CVoZzE+0uGcoHBjkx6+Nn84g4= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR11MB1466; X-LD-Processed: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;DM5PR11MB1466;20:na5VWTI2hGZIvpATOuPr952yWnSNHoKe/kemooN25lRhPI6fPDutylrD5ZduhSUK9GvtlMTMqNxKxEYKZQEDva3uZ/LmvY3eRHeic8kIg2sxqMcGAJq8YfqMyViYI1YkcpN3yyesqWSB6+IRH8Sbz/h6K71tqoZQmUNqpgsQMg4=;4:dz+A/ym3jmFQHiURLdgFAA3dl5Anu1tJRBMBeAyVyS7d4ZZB9yr8V2CtwhKZE2b4DYdG1tDfmYezi3UcYedLS2Cjkj7Bpq+TgKoojWAkPmzOfI8v7M1eWjFDjudPmq5Nv+fVzztWTc0E7cKxuYB41697g6fkGGxnwkSmDFDCFehfQSJRTCEaCUq/20r/rOPJUu9O+Ktp0S1JqITV9zBBt5vVTTP2HRI3qx/aCq+pYskxCsmKLycS6C+D4O7hTPmIY87rl/+6BrmCd9nJQY85BpS6OSOulRl+iCr2IysYF0e+vVsJQgI0/tVi6SWsrmEIOD5wAQJmnRfCrvpaAs4ESkblXVrxekUeTLtUFZAEcwtWeY2ABiDhm7RaG2MAqr/cv3TpwpEV2KsvYkuoyhJ7Sw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:DM5PR11MB1466;BCL:0;PCL:0;RULEID:;SRVR:DM5PR11MB1466; X-Forefront-PRVS: 00594E8DBA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(199003)(189002)(24454002)(110136002)(23726003)(83506001)(53416004)(46406003)(4326007)(50466002)(97736004)(81166006)(305945005)(4001350100001)(7846002)(106356001)(586003)(86362001)(81156014)(42186005)(101416001)(8676002)(54356999)(105586002)(7736002)(2906002)(76176999)(19580405001)(3846002)(6116002)(19580395003)(68736007)(47776003)(189998001)(50986999)(5660300001)(2950100001)(66066001)(98436002)(69596002)(9686002)(92566002)(77096005);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR11MB1466;H:n6018njbmq2l32.qlogic.org;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR11MB1466;23:j8CWEdqeCjMy5UrnN3XOnnWKyCQUEQFkTXduObU72?= =?us-ascii?Q?DvlclEFctDHsl+LNcJJpPZ6ZLu2chk82Jj386JUyEY+dwVocECi9wj5d5Eo2?= =?us-ascii?Q?bNZnBYfEse9vvw3joci18o/0L1jlox9suyH41cY/sbNEEKboa6FRQVBfFVm2?= =?us-ascii?Q?XAS++UBaOJzD+1V9ADGs/r0N3NVNHJ75NHSHgibDa/N1/WX+Vwr6/JCS927P?= =?us-ascii?Q?1P3/RUKemxLnV4l4dB04r7G/SbklcQRX/1UJ7BUoiwaWCRll670B0AdG3/fB?= =?us-ascii?Q?lHvYdJQHwFc06foeY0GOshitrxsuJeTgMrYOqrwRHGIAUr+vliAHRsHutTqS?= =?us-ascii?Q?RB2Db5gcLmCMh+V+FaG+H4ou4ygMIJAX5XPSJQQ0zt5SI1GyEGZhqv5EPfnd?= =?us-ascii?Q?qBqJP/VScBAbH1O1gwR7C1Om5haSOLajut0VvOweHR16eNAH+/mp9fV4120V?= =?us-ascii?Q?LK0pGDZNF8/HSCBBUbzI2ZscCD2Knx6lKCvwSrvFft6gi0MLqE+Iy4R6F4vy?= =?us-ascii?Q?bApJjC/GoY/OH7WXF3JSUdrsA94u4Pe+WfFcARztnFdXG3CiyTA0z5D64gWX?= =?us-ascii?Q?RBcIo8ohg7gM6ieC0SgzHLHrjCQxDqiWEIjGScxqvYo/7p7ZRZjxf3ErUrOx?= =?us-ascii?Q?rE05uoovVddg9Jcr0A410XYAhwr0jHsBrLz+vDLaHubM0ufgRyMYG9AWNTbp?= =?us-ascii?Q?jOEOVRvSAlRsx1n2zBxfxmMTC1QH1j7QEhPvL+fseQciTr9roFPJ5UpOhlLA?= =?us-ascii?Q?lYZxBxSHg8xqB7NaymGdYJpXwdN/EyAeBuhCtkfaNPIaozjymt6cqjhO7Ppp?= =?us-ascii?Q?YaQUXlPkF4/CEABWlgGiTgecyQAdPaaCXm6lL0FGPSaGh+ROwWpKXdcfOJlH?= =?us-ascii?Q?ILrA+kC/w9ae2HxS9GVsQuP0te/MWBTEmCVZt7LC1Ab+8I11hgnxsPzCVj4m?= =?us-ascii?Q?eTfhLA0kSrVMxiFa1oViZ39EEQJtbVH0J/lyqdsJkdiKmLnN6LwkKHHwqU7x?= =?us-ascii?Q?7Yo4rHJ2lUx4Fix8W22QQQE0OEoIoHg9IY/zPsoH8709bJMUOedKRKSRZvhj?= =?us-ascii?Q?2W0BzZDmOiK/46wQ1qAjyoxobAQNBEX3ykjFLzcPiCpV0CaKN7g+gLaWvan9?= =?us-ascii?Q?L/V1OijwewurEDwdiGPT2tf5+ebsIZCQC16CS9yho2dJF2SSJ1lMw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR11MB1466;6:Sw95NHH31o2c0vSdkvyNKHmH9tfrwXBDhWwZzsgPTrHGr4s19gexI07psXv+CpNkfujGOXtBvV5rJ2GhBgm8bJlOaqTuNYmNDKCjqz/G/Vg+Ru9RF0XqB/xF3KA448GNCzINsRzyPDbby5pbZH1DJarQNAl8Ujvm78ZAP77jIHJ4bbrBsNnCZhLLLtEU83OBbF8VupysnfNEqgaaRPAhNBVVapouQQq1mZAcR7K0sdYE5BvujmeHq+zhN0K0qr7nPh2VTcDvbE90xNMz9y88om8kvDs0t8EcNvW402oWR1w=;5:Si9WkCAxmPLcuBH2OYtFkTCL1bGOnvQrOyXT/CYQqW8rjiGn1DuR+mAeCknuBlD+dHiOHeVAHU3RE5pTLwzATp5oZxuaXREWNSuZKZqDFuemYu4nSBrv0wFaY+tbbv35nMstXpXOyTJPNLEvDP4h0A==;24:DnjUDC5ir3nnoBynTHSVHvFBWZcILMCTx7Yv+pXuv80kanY5mQe4QTXqJS/zT30RjKEeg1reizAg0r+EzvaFTwBsac5XdBMV8nvXXpMXG4Q=;7:OpQJ3YhrCbG9big2sSYZxlGTEpeWT++XRbsUP2NRiLivKS7EBtXm9fmWDV+ARXRwBDaXH5qWZKr1h8ybspbBblliohjmxe+tBfvUz+nUhvVCVlAsnbuKz9P2r1Av/rE2mE/msdDPL1xAHwLqNdfRJXwCBencwJ74RvUCziPFk2iKsz4tY/XF5+NyamnOkKTsDXsCh6JyauOqFQ58w94FKSg/bgZt4Xb3To4n4KO44MUk5PdcEndY+IfbM6BK0CY9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: qlogic.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2016 14:51:16.4369 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1466 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 4 Sep 2016, 6:52am -0000, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/scsi/bnx2fc/bnx2fc_els.c:257:6: warning: no previous prototype for 'bnx2fc_srr_compl' [-Wmissing-prototypes] > drivers/scsi/bnx2fc/bnx2fc_els.c:367:6: warning: no previous prototype for 'bnx2fc_rec_compl' [-Wmissing-prototypes] > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:628:5: warning: no previous prototype for 'bnx2fc_percpu_io_thread' [-Wmissing-prototypes] > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1413:26: warning: no previous prototype for 'bnx2fc_interface_create' [-Wmissing-prototypes] > drivers/scsi/bnx2fc/bnx2fc_hwi.c:997:21: warning: no previous prototype for 'bnx2fc_alloc_work' [-Wmissing-prototypes] > drivers/scsi/bnx2fc/bnx2fc_io.c:1082:5: warning: no previous prototype for 'bnx2fc_abts_cleanup' [-Wmissing-prototypes] > .... > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/scsi/bnx2fc/bnx2fc_els.c | 4 ++-- > drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 9 +++++---- > drivers/scsi/bnx2fc/bnx2fc_hwi.c | 2 +- > drivers/scsi/bnx2fc/bnx2fc_io.c | 2 +- > 4 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/drivers/scsi/bnx2fc/bnx2fc_els.c b/drivers/scsi/bnx2fc/bnx2fc_els.c > index 5beea77..68ca518 100644 > --- a/drivers/scsi/bnx2fc/bnx2fc_els.c > +++ b/drivers/scsi/bnx2fc/bnx2fc_els.c > @@ -254,7 +254,7 @@ int bnx2fc_send_rls(struct bnx2fc_rport *tgt, struct fc_frame *fp) > return rc; > } > > -void bnx2fc_srr_compl(struct bnx2fc_els_cb_arg *cb_arg) > +static void bnx2fc_srr_compl(struct bnx2fc_els_cb_arg *cb_arg) > { > struct bnx2fc_mp_req *mp_req; > struct fc_frame_header *fc_hdr, *fh; > @@ -364,7 +364,7 @@ srr_compl_done: > kref_put(&orig_io_req->refcount, bnx2fc_cmd_release); > } > > -void bnx2fc_rec_compl(struct bnx2fc_els_cb_arg *cb_arg) > +static void bnx2fc_rec_compl(struct bnx2fc_els_cb_arg *cb_arg) > { > struct bnx2fc_cmd *orig_io_req, *new_io_req; > struct bnx2fc_cmd *rec_req; > diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c > index a5052dd..5eb38c7 100644 > --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c > +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c > @@ -625,7 +625,7 @@ static void bnx2fc_recv_frame(struct sk_buff *skb) > * > * @arg: ptr to bnx2fc_percpu_info structure > */ > -int bnx2fc_percpu_io_thread(void *arg) > +static int bnx2fc_percpu_io_thread(void *arg) > { > struct bnx2fc_percpu_s *p = arg; > struct bnx2fc_work *work, *tmp; > @@ -1410,9 +1410,10 @@ bind_err: > return NULL; > } > > -struct bnx2fc_interface *bnx2fc_interface_create(struct bnx2fc_hba *hba, > - struct net_device *netdev, > - enum fip_state fip_mode) > +static struct bnx2fc_interface * > +bnx2fc_interface_create(struct bnx2fc_hba *hba, > + struct net_device *netdev, > + enum fip_state fip_mode) > { > struct fcoe_ctlr_device *ctlr_dev; > struct bnx2fc_interface *interface; > diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c > index 28c671b..5ff9f89 100644 > --- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c > +++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c > @@ -994,7 +994,7 @@ void bnx2fc_arm_cq(struct bnx2fc_rport *tgt) > > } > > -struct bnx2fc_work *bnx2fc_alloc_work(struct bnx2fc_rport *tgt, u16 wqe) > +static struct bnx2fc_work *bnx2fc_alloc_work(struct bnx2fc_rport *tgt, u16 wqe) > { > struct bnx2fc_work *work; > work = kzalloc(sizeof(struct bnx2fc_work), GFP_ATOMIC); > diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c > index 8f24d60..f501095 100644 > --- a/drivers/scsi/bnx2fc/bnx2fc_io.c > +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c > @@ -1079,7 +1079,7 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd *sc_cmd) > return bnx2fc_initiate_tmf(sc_cmd, FCP_TMF_LUN_RESET); > } > > -int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req) > +static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req) > { > struct bnx2fc_rport *tgt = io_req->tgt; > int rc = SUCCESS; > Looks ok. Acked-by: Chad Dupuis