From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753008AbdECS3u (ORCPT ); Wed, 3 May 2017 14:29:50 -0400 Received: from mail-by2nam03on0088.outbound.protection.outlook.com ([104.47.42.88]:31130 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751315AbdECS3k (ORCPT ); Wed, 3 May 2017 14:29:40 -0400 Authentication-Results: embeddedor.com; dkim=none (message not signed) header.d=none;embeddedor.com; dmarc=none action=none header.from=cavium.com; Date: Wed, 3 May 2017 14:29:19 -0400 (EDT) From: Chad Dupuis X-X-Sender: cdupuis@administrators-MacBook-Pro.local To: "Gustavo A. R. Silva" cc: QLogic-Storage-Upstream@cavium.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Senna Tschudin Subject: Re: [scsi-qedf] question about parameter ordering In-Reply-To: <20170503125818.Horde.8rEDF6U_fTKRV29evjbXFMa@gator4166.hostgator.com> Message-ID: References: <20170503125818.Horde.8rEDF6U_fTKRV29evjbXFMa@gator4166.hostgator.com> User-Agent: Alpine 2.00 (OSX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Originating-IP: [4.15.251.130] X-ClientProxiedBy: CO2PR04CA0079.namprd04.prod.outlook.com (10.166.88.47) To BY1PR0701MB1724.namprd07.prod.outlook.com (10.162.111.143) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6ec6245b-91a6-4ad5-0625-08d492525bd1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:BY1PR0701MB1724; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1724;3:eXYltC9qasZMudlC56lmmLI/DdG9aUsZXAkrTU7jNuwcmk7LYaHKeIUUNHfNwhrR0D7GUQgLZgOCm6xh0Brw4rUD/EhPH93+VedqG6lKqJkt7O/PxDKA+yRYgM5izXremzvFFca+c5rgNr+hfWXdC42Z8koddQ1LfwEQ9+qvLhQ6XxeAI9qvJrqbpEjPVABp9s79nucJlxvExCLyX7+PbvZLxZB7JPLDh4z8UcV60vsa4gv9VZZh+gkOIvKzKDitHYiodMjd1uF5o4qbHJCgUL2cBsXWfFrFpUIZvznt8bY3MVaBnNLDtXBMwlAWlOf3gVOtLUpH2TAGk7DMsrvT0g==;25:hOW8eLgR8/zFFj72t/vrMPsjqTuATKw+HUbTgmby+mXzggVF6Mbea6XmuyHbJeJmMuPvYSoxgLxO9pg+rTXLFvgKKQ3mA7IVANN4ceOQzmx5oA7MDGa3/XTIHzxpZJ/xk9cbWtUGDuBZ8AvUpcOnwwasdBedfAk2x1RxMRjLNuAyvAYJJssPHuynot88Udo99dLpRSpsyjn1sGo3sA+AuEezrbCehkdxYzjH6eF3N4VvDAyN7WfUni48wgGZEAf6N/8kNaZG2OFeY+SCHUDrloltqfFH+2UYZu1RpYzU974QK2VEoqPupJJ4bjlC22f/Ka3INCUbS4wWdbiEv+5W4PIoTkFj9qLF9tUUynVPN0tD4dQHkAVbfGOxa6dLQJoPGoWY8Ob8/ie4juc+LgCRmmnhvYLL/dmyLW9Fq+4bV9kvZjsFAvfLxKDUhSl8V5MZclnn67JFdGs6iDhBm6s8MA== X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1724;31:7Q/e3O9raeVR06sl1GmP++k2NlLgTedtwN7efSfG+w5/juk2HDoLevDCMh89NUl6rgVukh/MCAiZ0hHUnjJdfwcSIvGAh6z+xQc3gQHlOmMDdZ39FcWfbxZll4HJaPSO6sX5Da0qXdfhOz6jCluNvdDml9tYuiLrWIuODLfoUWyUM27hn9D1vRzTGQE+MUmq90bnWLY94QeNM9LemAIdEgdODQJu2cQ7li+utIe6RYhFlZ8MQIlFeb0I8JdXKKue;20:Un/8phnJR9wGDxc21A3056kmUllEMwIRUyKIx2IKNQyzEWMm5pDeZb3VVbErpD2kQ2h9kr2Xl8qbheKbozjXRCh7P9APhR2RVkAij2kgfreLEDccClkjBjRxiQOXu8PXk0Vcv40zK7ROFasUZXrriV8e/EwI6+8U4eS7lTDMbgCAR6pzDM6C3JA/Q1ujdm97WQRR9cfeLWhm5dgCd3TyRmUB7kDVlaKpCjcTE+3prw26vyRVibpMkvTZ6GYjIPU+0ls92f3VhUurlpmM6jVgXhOwx3ZS68sXdeDWmyFcbl7DsCnW8zGxoS9YpNat6DlSIM0oM7f1Two+GJAE7GWu6rTAFNDdudaAH2lrn/Pvl1Quw+/8HyV9AtJPbBtzHOTW3h2ygwUY2BiVs8AqLR1fEWVDH/iO6eesrwaCXcwSfZ2zehpwh6MIbOMqiCv3Db4ENe+ltjJPUhLEiabs8rfJCHairy6JF0dwPmc+7k7qMMzwmqTEbyVaTI+CZpGV8khq X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123558100)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148);SRVR:BY1PR0701MB1724;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1724; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1724;4:s7sSCgonfyOAMzD1e0/b3pAWXTE55yO046zu4EFl4iJwcCOFKewpDp2KHKCo9YRfGi8sCBgfxx1HudoQ2BHJ9NTXoD3Pw35t8FxAXEvP87Ay213eCvuy0ICZBdYYeClFnXpUvkcl26RLj3jrRMxSv7jMnt36E28o+qdLB6iMCevjSwYksq3nPHlbdkRiCf/OCVGfiwk0uAv4LMG/ulAQEKHEVw95DtsuvkFQwlgon6dUf6XoJYH1lpsyPRiHi/RXjZdcIbxc316RivUKs/gwa9t8apA0w4ydbat0jvp5Mhjjgs9isZ8cOQbHwUhpy8KfKdVpFp0pubMlBhPKt8OThGtNBdU222SL/uBnxULgGcRLhcUoMbd9cruDE6Y1ozl0WhtdoHLo97L1Bxwvj60Xh7t/mQB3apDble8FBhTkQyrj8dBj6iCFOAaXzw0O4ezV7YoLodlOuaT+KrV5/Yk8cI0ajWr7+CNdPo0uzPWNSeGuY6AOn50qj2Jlg4l6OeHyN8ZggMlxbYYooK6Poz6odbxjlnVAf+UZ6XkoCxzrwKAnX3gJQn0IvRQFCM/SSIVLRTgYVvQh5wlkC9/urzx60WM1G5oYiio86tKbYhh9bk2yqeVBruE8Bwzi7WUNst21hQarM0f+ox6XlFVe+MN0Rb8LNhMssKSJuCr4DPHzvhyKyqRALdMnChOUgbPdWZ3OPEaRHjjEMjrbXwxllKetpYYA++ldgYv1EUCa5TKc9b0gja0MsX2tgFszVNf+8VdUjxAzuOLbCCznMT9LtUPnht8C7l9aIvpjadtIP1Qeph4= X-Forefront-PRVS: 029651C7A1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39840400002)(39850400002)(39410400002)(39450400003)(39400400002)(24454002)(54356999)(50986999)(76176999)(86362001)(42186005)(5005980100005)(2906002)(8676002)(25786009)(478600001)(6116002)(5660300001)(3846002)(7736002)(305945005)(4326008)(23726003)(229853002)(6916009)(2950100002)(47776003)(83506001)(77096006)(98436002)(6246003)(38730400002)(110136004)(53936002)(189998001)(54906002)(4001350100001)(9686003)(6486002)(81166006)(90366009)(6666003);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR0701MB1724;H:[10.33.7.193];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR0701MB1724;23:QsApMgvqKtxRETtwEKoK+eJDBv0+kOpLRd9nDc7?= =?us-ascii?Q?OqbQXXR37CR4MQhqM+F+4G1tGZu8XUQI0385/mAFIrOTNqbFLxpLBJ3xfnCo?= =?us-ascii?Q?wzs8qQDxZlGDJaUMNL3sIlERNo9XyF4zgWOViRGI6vHCpCLyKNhMPxQbccZx?= =?us-ascii?Q?jx8bJY4p+t5vt3zQJDuFbr4Yp96kXmpanDTu8q7X+vIDbgiIWGhzUQpHSJff?= =?us-ascii?Q?yKG78zTt3KXsYnKEt5Qb7enemldcYNiwodEi/WkoKZjzD6TXf9BYWdd1qNHw?= =?us-ascii?Q?4sfEEtY0PWOCbUdL5t2+WSprs50vwMTJVCgUJgtRdLzlpk2ld2G/vGgWXetE?= =?us-ascii?Q?ckvVwHxFLYlAkgQ0HP4SwTmLtgsKw2PW0+Of2KVuAxbeTN8FLcElMH1oLsfv?= =?us-ascii?Q?azQE/tGNR/adRsI9E6ejyPk9R0x/rCBYY8cXfNw/inFRRNwgNBHo8qSzpeEe?= =?us-ascii?Q?4Ax6vRA4UCivasojM2h1/oqs4E9APo/L0ju2y91PVzFtD7w9CmJmYbD3cWW2?= =?us-ascii?Q?mpJNmSpzai7rQEaMhY2hIOINmkh4lH+5VbnGG7Rk9xxZ0SGXkQtEUbplkL/r?= =?us-ascii?Q?WO4wADv/Mv9DyGjLHgvaMs8dRAXW3TAayvMYsPr3ndqcJNrO3gHFQbz0RY7O?= =?us-ascii?Q?zrze6x7QBrAQotu2FVC5SBEuGP0Ry/ltt+rbqcs16kexu2iQcaYHXqMXESAW?= =?us-ascii?Q?/dmABmfCL6upMVrDClBJOI2bkoZVSl9un1oSCvWsnWK9LMvsilAyKcteHO85?= =?us-ascii?Q?rxPAqVyNuFy1o7vd6x4KqGatp9Z5K6Lp0uVpPTLcBHCsMlfouCCwgTksfzLg?= =?us-ascii?Q?yu1eEzIsWxcVpVRveGEx20oBYjgf6DtLVaCVSXm8LNZvBRL0ohDasytY8/Wy?= =?us-ascii?Q?yH1VlnoVJM4V9uVOhAH8sNdBkjs/CUZsbgWQMYbJABDLBAi8zSFa/E6ZCyda?= =?us-ascii?Q?0crvNCafcnx5Qp+ZKCm/MXLjgsyX5HjrDcR52kfoCkMjME6FHHN5E/e/fM4X?= =?us-ascii?Q?ytv1IJFJo/ovq1jECsIEw5Q0qnJLp3Zwx22qOmLq9QslBlUMh8Zq/f8UMsrQ?= =?us-ascii?Q?Vy8Oqr9doARtZw7S1rXmQEq1/8NjEWkQqk3Cy7WLPCc9WGcyeFZH42aOj6Rx?= =?us-ascii?Q?ht8HNL2LDj/Ikzh8/O0UmZ1wqqYl16jqS?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1724;6:MWzr5wWflTv1gMOEFci/esmYG33sdyCaMkyWsIF1q0JqH3Jx7j07SHHTBqtgpal/p1xIhjSu0ThBUYUWZwM1kTjiGxTlq+LSkIUi+zkuOh8F64HagMbSG4/8POUl2biXaiiXtL3yiMV7dQ9oU3QUNIxY7Gp3q6K6KoI3jn4+XndWO/SCos5tKfz/wDHGt8SRPwa0kxzJg+qlb/+te0RFOt/JfEMr5oIiRKe7Ki/lyngFRG072h1pnaDGlIIC3amz9fgGjAv+msLEUF5FLHkqgcw2NHsI2V9nYid+iVFw7ZXJjqojvCPVdRJabRURydlVXk+5jyMWsWZpDJJ0U9Z8bogDdc4fgYCvKXU7xfFcTSGpF+fmqQpygk2lLhulbpJEnKrplVhy5KdyFk//A/D896q+CkzZvJPG7uwb4M7cMPlk7hVTYOYo1EW0WM33dekFSwBtUlwCQMbElES4eMdWI1cGfg58V7dQhLjQU5tEN0pqUC+tKLWilLJnOOHq7Zpa5RGu7K0noyYcmPov+y0JIg==;5:Pc0PLzkurH/hF9+XdsyT2Iz43sYPLCnZ3VLD8HnnG5B++1DANIPGSK50naXMaED1/744jLHYylE1HyzBcaXBcsr9fNitVHM11UWStGtvSArxDBpiDG5zzbCOnnb/d7F9GdFA4LGIuNuO79YzaWeX5g==;24:HJjUB8h41dRQVPav2ZP271GXIWtmyfc2dLHDt3FmvnlXe/YJkdJOZcA0rgePS4DLeKFt+txngkVM6O4obhPDO2ogIxRzrAZmvzFcxj57Vu8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1724;7:mvWXsTuti3klObV7s8Ha9xZZI1gamvLFzLhpJzwfEL3Tm9YwZKdz5j1PZzM+ZZGL8ceg/rbmo8QLN7fIPZ55Vc9B+TisI9j3cfbiVl0WPqeAsGh5X8uk+q7Ef9U6FMROZynKxL4zxQfdyjSsTitjmusByeNkYhSC35KpFrQeFUk4B+q1A4btUBHM7p4QhiD2PsgERTGc7V/0p4kFlC8dN7g0trEg+rTrzIsRXsdv7QcdifoMnOCtr642LjJrjziJQG3859sW0/gvtpHyiWX4O0mAUfzQqi8poh6MJyIFwMu1ApTPS2noXDnM8QTFE5qAfLa+Gh9V+lVUf9IdZjpOxw== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2017 18:29:37.8512 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1724 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 May 2017, 1:58pm, Gustavo A. R. Silva wrote: > > Hello everybody, > > While looking into Coverity ID 1402011 I ran into the following piece of code > at drivers/scsi/qedf/qedf_io.c:2057: > > /* Fill FC header */ > fc_hdr = &(tm_req->req_fc_hdr); > sid = fcport->sid; > did = fcport->rdata->ids.port_id; > __fc_fill_fc_hdr(fc_hdr, FC_RCTL_DD_UNSOL_CMD, sid, did, > FC_TYPE_FCP, FC_FC_FIRST_SEQ | FC_FC_END_SEQ | > FC_FC_SEQ_INIT, 0); > > The issue here is that the position of arguments in the call to > __fc_fill_fc_hdr() function do not match the ordering of the parameters: > > _sid_ is passed to _did_ > _did_ is passed to _sid_ > > this is the function prototype: > > static inline void __fc_fill_fc_hdr(struct fc_frame_header *fh, > enum fc_rctl r_ctl, > u32 did, u32 sid, enum fc_fh_type type, > u32 f_ctl, u32 parm_offset) > > My question here is if this is intentionala? This may have been but this code has been superseded by commit be086e7c53f1fac51eed14523b28f2214b548dd2.B > > In case it is not, I will send a patch to fix it. But first it would be great > to hear any comment about it. > > By the way... the same is happening at drivers/scsi/qedf/qedf_els.c:109 May be a bug here so you could send a patch. > > Thank you > -- > Gustavo A. R. Silva > > > >