From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753508AbdECSuf (ORCPT ); Wed, 3 May 2017 14:50:35 -0400 Received: from mail-dm3nam03on0055.outbound.protection.outlook.com ([104.47.41.55]:61251 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751159AbdECSuY (ORCPT ); Wed, 3 May 2017 14:50:24 -0400 Authentication-Results: infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=none action=none header.from=cavium.com; Date: Wed, 3 May 2017 14:50:11 -0400 (EDT) From: Chad Dupuis X-X-Sender: cdupuis@administrators-MacBook-Pro.local To: Randy Dunlap cc: "Gustavo A. R. Silva" , QLogic-Storage-Upstream@cavium.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Senna Tschudin Subject: Re: [scsi-qedf] question about parameter ordering In-Reply-To: <16696718-27c6-b5a6-912d-f5efc592df76@infradead.org> Message-ID: References: <20170503125818.Horde.8rEDF6U_fTKRV29evjbXFMa@gator4166.hostgator.com> <16696718-27c6-b5a6-912d-f5efc592df76@infradead.org> User-Agent: Alpine 2.00 (OSX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Originating-IP: [4.15.251.130] X-ClientProxiedBy: MWHPR17CA0077.namprd17.prod.outlook.com (10.173.237.143) To CY1PR0701MB1726.namprd07.prod.outlook.com (10.163.21.140) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 552722fe-7103-48a2-83af-08d49255413a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:CY1PR0701MB1726; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1726;3:IeiJZfTkRZMxNguNK0NB+TZv9lje8p2nKcwIOhd/LajgoNloSB4eG7Uw56jUXbPKnAQ2tMfrBKUhenuEKVLJ5PBSvshnmB4aKG5U4TkxKpA8m+f4Dlm643TkBxRT5td/PrlFXXud+BU3EJi4C+UyVfZBa4gMaqkMfdie4jeOYEthWR9eQIOHEaxBnewMy2X39vlRFxh11Jvwl2kjFmlktBkoUbSRjnDdSJzM/3SIELEGgydGFQqXbg5EaGgjrR7+w6al5wXhoFpsC181j9JE7B8dhgb/VSCCjtmAg00UDmXglZEsrw+mO6iUJiTeoaZjH6I8VW3zDr01mDnUrDAASg==;25:hGHb2iFf3Zkhzyi4IIzHalL6Zhus3/HIl8ci7jmI7Mk93pbRgVpBOnt4TbGn19a2aCW1pETWB2zlbAY+b3FhIIsVW3w1eE0HJvIhn+MS1ISVFkA10Htp+ReYs5+5Qxq35SoaX05Liha4stx834CKQJBCnFQuCkLiqKtxc9qz8OZ/SbTmta0HcTB18YTtw08WKf7Oa+thKCpFlE9V+ZA5gufCR4kD5S7WR5mUmbx4oLuJ69v/rSCdOWuiOtQ2+XrOI78gRN+OP69bv1YRYSIWwRO43TQSWYT4CuCxOnHU3ATdq1f0zMaRwEl09AJ7GGTNH3TfyMzoz/RPznrlPCs56JsubYU/ALAwamY6AlgYNRV/wZHxccE6zs39Zj2AWYV12PGrh0JaIhBxwRN76U3jk/cquRRO5SbMmuAnzepuyKZ8urlyUFb1bFDfH+xmyhvKmXDXxQT7AdLMQ9nZDRDBZw== X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1726;31:/AAuhaBQc/ahQZCFgRjXX6W6iLAE9/JJCuSGC+LIYZxLOA3QSHud0XI9K4dYLoJBvDZSHEQekkHVkDCKtuNNbNwhs12ULON3FSNbnC8RzOdO7wuS9srzPtRkNYIJN2SA4CPr195ay+l6EtLvDep3FOyMWSr3cJqK35HfopdaZifG1JUtqv04zktCwLtSDR7doXUpuslXaMNSEQDpL/o8N4cd/ikFb5jgSoePz/XeMb12Pg+O+nvyrIah2HQMyRoA;20:kSSwN++hteL6W/L8/XGKv26tzvLkeLoYI0L9dz8cpY+JsY5QmWc4kw01BYNf3/mI5WNsOApLwfMs68AeAnjR/IyW1XqgYh+3tjZ8195FpoQVeN2mGWIpqHloDBBloDMtYbpWungE9NSu4mkN4l4LXvKbetEoFju7sUruO2kgMgwPdMvZF0KJ6ubeJl1Xuhh3Jr2S+Phjs92dJRjodV5ixJAlHxgIJFMQwRQK2rrLRKD6hE09fI7GBe/IdDHC3BLs5SX6IvnqimL4gUL5G/7dAaTTFffNlISWrmM8yDOYoChtYQCzO6UL+e78J7m48WZFV+ksiOAs7NZy/18ektuHZG6qd0Ms4qGGwXeKCsLz1yFiTt79q4HmLdD6zI/1sfZ4kOiRpMhDHJu2CF72LP8Wx48zMLAe6t2/2bvE/PdO/qiKQkts6AiAX8riE4lBj4NXmgO8NEPhUhev70YalG1ClfydfimwwQA3eBDRx8GZdcUOjOvOnpWpzX8rSlI/GOIu X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148);SRVR:CY1PR0701MB1726;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1726; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1726;4:ZrCte5wqzPz2o0YvJ93HZ1ZkASIXHo3JFB2/MQKMfx7BVdDbGhhOPWmb2Vu7VcB6//qb/H/bhpKFW+sWzKW3UJvD/D2KSCrHzzh/fM5XJf85j87I7ORz4o19NEMCnn2qMJRXpfxKsetTBXXR9mNAO5XbR0QyNze1dzzeyLfce5se/4V5ChIHNttGvNVHBtYTr2kxtDUMMwRMBH1Sl+6UTmsM6mLvk+pTfAcQkIUUQbrqAUYl8/VHmnsYBziyaTnVRhQrdhj/UM5XB5ZGYpln2Yidm4GsSCjn6ccW90JHjhuXpXdHFwmQm6bTn1EcQmS11TG38fgWCBALQBDtF5HgxyNXXuqsrK/MgKULipJXJ96Dv3dXMimOqLhmjxzakDZ+f8O7tMr0TgytVs3++ZCWi28f24v4TmQyHr1xZyswD/xGFOZEH0AxQxZ7ohHJvlJ59Gc8ZjrqtWwlfgmft1Ns4hLrcndoL7E1HRZtoKr38HcrMFdqs62anvCm+vJUp+FsiDIidkzXA0yVGkCpT85x5k4dgdanBdKZfiauTl5z3QZ4DhygCHXdCtSwTvj3BO3ltqZwZODX03VxKJEJi8v9H8wEi01S4DG2NTQdyZYAE8BRpxCwdvT9jg7LNLVnjXrKp1FQGvgFbQWc7KXcGYE9MiS86HviKCyh7LLEIlVhquUL2ksGwTj+NYY7es3jzNUg29CbeqH2TuoMNHxn4bHgtoHj+36MCJvyhVo8kuHgToG8OcDquFEeAxqqUAffKcLzqBzFtiEryTCfRNX/la3SpiAdgctUp3EsdzjscyMD9qk= X-Forefront-PRVS: 029651C7A1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(39840400002)(39450400003)(39410400002)(39850400002)(39400400002)(24454002)(6486002)(77096006)(478600001)(229853002)(42186005)(5005980100005)(6916009)(50986999)(53936002)(90366009)(6666003)(86362001)(83506001)(53546009)(8676002)(4326008)(5660300001)(25786009)(81166006)(76176999)(47776003)(54356999)(2950100002)(98436002)(23726003)(3846002)(6116002)(9686003)(54906002)(6246003)(4001350100001)(110136004)(305945005)(38730400002)(189998001)(2906002)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0701MB1726;H:[10.33.7.193];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0701MB1726;23:3Uy1KAqaaOOYKxG8HqEIbDFPKxCM4RYZmhpWP+J?= =?us-ascii?Q?txj+yoCjz0Png1u5A9QvBJtngDtAbI77uWtwiX3RDeTLfU0LdYQWU3a14tuX?= =?us-ascii?Q?KVmZHEfRd2oSkBB7QVyqjTUI6nBcWUEZ4NyZlAkyKCFCad0IeAiqX5h5JIe/?= =?us-ascii?Q?9lM2Z2yftpYn68YS9X19oARC54p3KgLF0FWiuwspBBItPflskKi93KuQN0ct?= =?us-ascii?Q?tTkq7LXU9hU4iFwA7S2bN6kQH0gv6hOnzqESxBjem+t6uISzEkgn4LP8JHvv?= =?us-ascii?Q?FSPIAif720eTDthpTNNprb1wHJdK78rwhybCHyjn4tpcDtbrVmGRP16UnIRG?= =?us-ascii?Q?t5nLfDrne3ivU0evgp7oL+JIn4H3lVGCRatTvxHAG9by0yXFs508mW2zBfiJ?= =?us-ascii?Q?8CtrR3aMkwb/LXHEzAAoiXZZbaS4U18lfmPLLjUGLBV4ygUQF8ICOH68Gk8i?= =?us-ascii?Q?qnOv8B1jtrENhs5TJgHRAZXfQOEDKBkNjig3Df96TVsVyPN/3Op22z3ZgTBE?= =?us-ascii?Q?3pOcC7BTPyIWU0r615GkgcPKq0dZUvcIdlX2Kam2dygEFf5GNP5pk5GYs+un?= =?us-ascii?Q?SzF/CIw/ejgXURoQ/rqsx3HzzIAWgSIJf0e/10kSF4BEF7JR8yvJ6LbqRz/+?= =?us-ascii?Q?TnoD9iQzGTOMahn/r8by+6F4zOMPvLthhM14SHY77oBTfnX2kzNhsOUwvG4g?= =?us-ascii?Q?n1D7/rSDuUumESXG2StDBZ3+AfLWglt29HUjeXn12dhynuW44snjGiGrVKO2?= =?us-ascii?Q?iQFgzvNrqQT3fsFv3feugQ4nRVUDJSTK+x78c97ewgBbOo6D+HWFUUkxEkv2?= =?us-ascii?Q?nXqbD0eKt2Qj+B03fq07weCiOgTFeVvU5V92d3JGntNne7l3b7k9pmp3LDbH?= =?us-ascii?Q?HBcHxaXN43XZTg9m40svcq6eEnC0S8Ww2faEOiJPE3O6Bj1Y9/dPKLyQTjlj?= =?us-ascii?Q?n1jUJCPvkyYKFHy+LYaBftgPo6D6rj5oqHz70zN7UdQbEaNQhPXASq1ff7cX?= =?us-ascii?Q?d5VQNVFxeymj2A8zmvibfHc1Wyd6PoM/aBDHgmvRlY17wvoSM93/lchaABIH?= =?us-ascii?Q?wpt2Ozu7rFdS1lNIO9/QQjhm3BVAnPVlWSCu8kxPTiVyynXi+UHXMe1F/Q44?= =?us-ascii?Q?x037cvSWISxnaOYoqzwjRpahUCUmc1sEr5saVRwlX1c9fahiG/5qdgA=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1726;6:355CkPBuaNB2wv8NHOJ88w0oUpQzDAE0sLGmzkDnlGfW0vgTidz7gXB0GzmZUyxADG0y40tydU2lP7kEPYtiqIMurZFsEd/j1WampAH0hAU+nVPTihbPsHl/vTzAekFmBoy7RdSV4sqVQjvgzdl7e1P7iy4ku16IyQAv6BaTc9SZXCPJ9g/xM4RtzXUNusNSXt4ndhMW2fw9ogDnMdkjTmTqQIg5W454YYtlSpMExSvTChmHDqgoWkt8D4HKRna5qpVYe16JlzzMDRHPbFLmhJS5EsEJVb3OyR5inRfRQu2cxeWxasVyaOKWZaS0somSytigaOEWygTN73nuMWyFTjp8EB6sr1Ij/AcV5a8KAGfouZHT+Yf22xAAiGMY9661VPyXlyHD+7NgiS9TRIMQ6J61dzw14LKlSbg72ZAZldQDSbZMxOFTqFqDYlBxWJx3BPsiml6uLit9z0FK1Wt72n2MDktKrZBQBnYzKMfQNFrYq+Ro3puIOg2TGHd/RLaCKnbHgJ492CYAG38LEMPnpA==;5:NYJvj+yDhO8+zWN2a3v5I1CwPjg+79YpZuk4Werf8X/r9gzdQBXzg+BHHSv1yijm3Bnc8VutkDYQZAeHE1QhViy5WskAlQYEXjxkbWrOXAkZzQs9+8gk6Hf7bEPSwiDZH3z+HmakOeX+h8wBdrW3zw==;24:375F9cqoHL9T+Nly+UUCpBHxDI4PAzSs9XmMV5xKahA6gMaqFUtC1ZMOrnGdCLRN2bhPbo4isjXF0uhpkYg4dKie+NLN3q86mI946YLkwE0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1726;7:QLT9Aqj6HXaZO24XHHznQDuDGRwCqZ8jSQ7IE+mHgHTfVxxubggYbUlIY24zjLhqPHxZYxzjRgjtNB19NcevcJd/3QLZ9WB5tL+9xx1EZuIScHIBWF0zr3zogvE3zUPA28dvh5mOB2WraURrBarG5dE+pwhMnLRhhBzrUd+j5Xfivh6pp02klFEFU3YvBmbj7fa0JJCb6/4ntJleERkPOYH4hOxV8f4J/8eoWYBcddvstBkpNtWnXiZSp6ahvzyWaOQEU+mHQlYGC9DaRF2CAn7SVoCuTKZFmUAQZNgvD4fjf0DB6wnnDFsh2hvMwIs6GyzpgnVZ97nNA1sX8yZqkQ== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2017 18:50:21.2342 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1726 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 May 2017, 2:36pm, Randy Dunlap wrote: > On 05/03/17 11:29, Chad Dupuis wrote: > > > > On Wed, 3 May 2017, 1:58pm, Gustavo A. R. Silva wrote: > > > >> > >> Hello everybody, > >> > >> While looking into Coverity ID 1402011 I ran into the following piece of code > >> at drivers/scsi/qedf/qedf_io.c:2057: > >> > >> /* Fill FC header */ > >> fc_hdr = &(tm_req->req_fc_hdr); > >> sid = fcport->sid; > >> did = fcport->rdata->ids.port_id; > >> __fc_fill_fc_hdr(fc_hdr, FC_RCTL_DD_UNSOL_CMD, sid, did, > >> FC_TYPE_FCP, FC_FC_FIRST_SEQ | FC_FC_END_SEQ | > >> FC_FC_SEQ_INIT, 0); > >> > >> The issue here is that the position of arguments in the call to > >> __fc_fill_fc_hdr() function do not match the ordering of the parameters: > >> > >> _sid_ is passed to _did_ > >> _did_ is passed to _sid_ > >> > >> this is the function prototype: > >> > >> static inline void __fc_fill_fc_hdr(struct fc_frame_header *fh, > >> enum fc_rctl r_ctl, > >> u32 did, u32 sid, enum fc_fh_type type, > >> u32 f_ctl, u32 parm_offset) > >> > >> My question here is if this is intentionala? > > > > This may have been but this code has been superseded by commit > > be086e7c53f1fac51eed14523b28f2214b548dd2.B > > what git tree is that in? > > Thanks. > Apologies, a couple of stray characters got into the commit ID. This is in mainline: commit be086e7c53f1fac51eed14523b28f2214b548dd2 Author: Mintz, Yuval Date: Sat Mar 11 18:39:18 2017 +0200 qed*: Utilize Firmware 8.15.3.0 > >> In case it is not, I will send a patch to fix it. But first it would be great > >> to hear any comment about it. > >> > >> By the way... the same is happening at drivers/scsi/qedf/qedf_els.c:109 > > > > May be a bug here so you could send a patch. > > >