From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754469AbcDKWWM (ORCPT ); Mon, 11 Apr 2016 18:22:12 -0400 Received: from mga04.intel.com ([192.55.52.120]:14640 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752860AbcDKWWH (ORCPT ); Mon, 11 Apr 2016 18:22:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,470,1455004800"; d="scan'208";a="83299765" Date: Mon, 11 Apr 2016 15:21:59 -0700 (PDT) From: Mat Martineau X-X-Sender: mjmartin@mjmartin-mac01.local To: David Howells cc: zohar@linux.vnet.ibm.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 02/12] PKCS#7: Make trust determination dependent on contents of trust keyring [ver #4] In-Reply-To: <20160407085811.29311.8948.stgit@warthog.procyon.org.uk> Message-ID: References: <20160407085756.29311.46761.stgit@warthog.procyon.org.uk> <20160407085811.29311.8948.stgit@warthog.procyon.org.uk> User-Agent: Alpine 2.20 (OSX 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 Apr 2016, David Howells wrote: > diff --git a/crypto/asymmetric_keys/pkcs7_trust.c b/crypto/asymmetric_keys/pkcs7_trust.c > index b9a5487cd82d..0dccb6fe7634 100644 > --- a/crypto/asymmetric_keys/pkcs7_trust.c > +++ b/crypto/asymmetric_keys/pkcs7_trust.c > @@ -170,8 +162,7 @@ verified: > * May also return -ENOMEM. > */ > int pkcs7_validate_trust(struct pkcs7_message *pkcs7, > - struct key *trust_keyring, > - bool *_trusted) This doesn't build after the keys-trust branch was rebased on v4.6-rc2. A reference to _trusted was added in commit e5435891 ("PKCS#7: pkcs7_validate_trust(): initialize the _trusted output argument"), right after the local declarations. > + struct key *trust_keyring) > { > struct pkcs7_signed_info *sinfo; > struct x509_certificate *p; Regards, -- Mat Martineau Intel OTC