From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753894AbcEMXck (ORCPT ); Fri, 13 May 2016 19:32:40 -0400 Received: from mga04.intel.com ([192.55.52.120]:14836 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751759AbcEMXci (ORCPT ); Fri, 13 May 2016 19:32:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,615,1455004800"; d="scan'208";a="805921731" Date: Fri, 13 May 2016 16:32:35 -0700 (PDT) From: Mat Martineau X-X-Sender: mjmartin@mjmartin-mac01.local To: Tadeusz Struk cc: dhowells@redhat.com, herbert@gondor.apana.org.au, smueller@chronox.de, linux-api@vger.kernel.org, marcel@holtmann.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, dwmw2@infradead.org, davem@davemloft.net Subject: Re: [PATCH RESEND v5 6/6] crypto: AF_ALG - add support for key_id In-Reply-To: <20160505195120.1843.35821.stgit@tstruk-mobl1> Message-ID: References: <20160505195048.1843.7817.stgit@tstruk-mobl1> <20160505195120.1843.35821.stgit@tstruk-mobl1> User-Agent: Alpine 2.20 (OSX 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tadeusz - David updated the keys-asym-keyctl branch, and this patch set won't build any more. On Thu, 5 May 2016, Tadeusz Struk wrote: > diff --git a/crypto/algif_akcipher.c b/crypto/algif_akcipher.c > index e00793d..f486b6d 100644 > --- a/crypto/algif_akcipher.c > +++ b/crypto/algif_akcipher.c > +static int asym_key_encrypt(const struct key *key, struct akcipher_request *req) ... > + params.data_len = req->src_len; > + params.enc_len = req->dst_len; The params member names have changed (now in_len and out_len). > + ret = encrypt_blob(¶ms, in, out); The encrypt function for the key can now be called with params.key->type->asym_eds_op(). This also allows you to factor out the duplication in asym_key_encrypt, asym_key_decrypt, and asym_key_sign. See keyctl_pkey_e_d_s() in keyctl_pkey.c > +static int asym_key_verify(const struct key *key, struct akcipher_request *req) ... > + ret = verify_signature(key, NULL, &sig); key->type->asym_verify_signature() is available as well. Regards, -- Mat Martineau Intel OTC