From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752764AbdLHRw3 (ORCPT ); Fri, 8 Dec 2017 12:52:29 -0500 Received: from mga03.intel.com ([134.134.136.65]:9048 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbdLHRw0 (ORCPT ); Fri, 8 Dec 2017 12:52:26 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,378,1508828400"; d="scan'208";a="1031831" Date: Fri, 8 Dec 2017 09:52:24 -0800 (PST) From: Mat Martineau X-X-Sender: mjmartin@mjmartin-mac01.sea.intel.com To: David Howells cc: Eric Biggers , keyrings@vger.kernel.org, syzbot , davem@davemloft.net, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Eric Biggers , stable@vger.kernel.org Subject: Re: [PATCH] KEYS: reject NULL restriction string when type is specified In-Reply-To: <31869.1512744350@warthog.procyon.org.uk> Message-ID: References: <089e082676ecdedb0b055f394f11@google.com> <20171130205159.97771-1-ebiggers3@gmail.com> <31869.1512744350@warthog.procyon.org.uk> User-Agent: Alpine 2.21 (OSX 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Dec 2017, David Howells wrote: > Mat Martineau wrote: > >> Since this fixes the bug for the asymmetric key type and ensures that other >> key types won't make the same mistake, I agree this is the way to fix it. I >> did not find any issues in the patch. > > Can I put that down as a Reviewed-by? Yes. Looks like I missed the window for your pull request, though - I'll be sure to add Reviewed-by in future reviews. -- Mat Martineau Intel OTC