From: Marc Dietrich <marvin24@gmx.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Amir Mahdi Ghorbanian <indigoomega021@gmail.com>,
marvin24@gmx.de, devel@driverdev.osuosl.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
ac100@lists.launchpad.net
Subject: Re: [PATCH 2/2] Staging: nvec: nvec: fixed check style issues
Date: Mon, 17 Dec 2018 20:48:04 +0100 (CET) [thread overview]
Message-ID: <alpine.OSX.2.21.1812172039250.96577@macbook-pro.fritz.box> (raw)
In-Reply-To: <20181217081640.GA16368@kroah.com>
Hi,
On Mon, 17 Dec 2018, Greg KH wrote:
> On Sun, Dec 16, 2018 at 08:57:43AM -0800, Amir Mahdi Ghorbanian wrote:
>> @@ -626,7 +628,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>> break;
>> case 2: /* first byte after command */
>> if (status == (I2C_SL_IRQ | RNW | RCVD)) {
>> - udelay(33);
>> + usleep_range(0, 33);
>
> Why is this a valid range to sleep for for this device? Have you been
> able to verify/test this?
oh no, not again. Why does this come up again every half year? This udelay
is a workaround for a hw bug which only seldom triggers (if it triggers at
all). Secondly, this is in interrupt context, so *sleep timers are no go,
afaik.
Marc
prev parent reply other threads:[~2018-12-17 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 16:57 Amir Mahdi Ghorbanian
2018-12-16 17:47 ` Joe Perches
2018-12-17 1:07 ` kbuild test robot
2018-12-17 8:16 ` Greg KH
2018-12-17 19:48 ` Marc Dietrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.21.1812172039250.96577@macbook-pro.fritz.box \
--to=marvin24@gmx.de \
--cc=ac100@lists.launchpad.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=indigoomega021@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®