From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MALFORMED_FREEMAIL,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEA8BC2D0C1 for ; Thu, 19 Dec 2019 17:48:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86BA1222C2 for ; Thu, 19 Dec 2019 17:48:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726960AbfLSRsK (ORCPT ); Thu, 19 Dec 2019 12:48:10 -0500 Received: from mout02.posteo.de ([185.67.36.142]:46773 "EHLO mout02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726855AbfLSRsK (ORCPT ); Thu, 19 Dec 2019 12:48:10 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id DFECF240101 for ; Thu, 19 Dec 2019 18:40:47 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47dzgL4SfTz9rxM; Thu, 19 Dec 2019 18:40:46 +0100 (CET) Date: Thu, 19 Dec 2019 18:40:45 +0100 (CET) From: Marc Dietrich X-X-Sender: lucile@macbook-pro.fritz.box To: Xidong Wang cc: Marc Dietrich , Greg Kroah-Hartman , ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] staging: nvec: check return value In-Reply-To: <1576648598-12257-1-git-send-email-wangxidong_97@163.com> Message-ID: References: <1576648598-12257-1-git-send-email-wangxidong_97@163.com> User-Agent: Alpine 2.21 (OSX 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Xidong, On Wed, 18 Dec 2019, Xidong Wang wrote: > In nvec_kbd_probe(), the return value of devm_input_allocate_device() > should be checked before it is used. > > Signed-off-by: Xidong Wang looks good to me. Thanks! Acked-by: Marc Dietrich > --- > drivers/staging/nvec/nvec_kbd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/nvec/nvec_kbd.c b/drivers/staging/nvec/nvec_kbd.c > index 01dbb66..386d619 100644 > --- a/drivers/staging/nvec/nvec_kbd.c > +++ b/drivers/staging/nvec/nvec_kbd.c > @@ -123,6 +123,8 @@ static int nvec_kbd_probe(struct platform_device *pdev) > keycodes[j++] = extcode_tab_us102[i]; > > idev = devm_input_allocate_device(&pdev->dev); > + if (!idev) > + return -ENOMEM; > idev->name = "nvec keyboard"; > idev->phys = "nvec"; > idev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REP) | BIT_MASK(EV_LED); > -- > 2.7.4 > >