From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Paolo Abeni <pabeni@redhat.com>,
Christoph Paasch <cpaasch@apple.com>,
Matthieu Baerts <matthieu.baerts@tessares.net>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, mptcp@lists.01.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mptcp: MPTCP_HMAC_TEST should depend on MPTCP
Date: Wed, 29 Jan 2020 13:08:04 -0800 (PST) [thread overview]
Message-ID: <alpine.OSX.2.21.2001291246140.9282@cmossx-mobl1.amr.corp.intel.com> (raw)
In-Reply-To: <20200129180224.700-1-geert@linux-m68k.org>
On Wed, 29 Jan 2020, Geert Uytterhoeven wrote:
> As the MPTCP HMAC test is integrated into the MPTCP code, it can be
> built only when MPTCP is enabled. Hence when MPTCP is disabled, asking
> the user if the test code should be enabled is futile.
>
> Wrap the whole block of MPTCP-specific config options inside a check for
> MPTCP. While at it, drop the "default n" for MPTCP_HMAC_TEST, as that
> is the default anyway.
>
> Fixes: 65492c5a6ab5df50 ("mptcp: move from sha1 (v0) to sha256 (v1)")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
--
Mat Martineau
Intel
next prev parent reply other threads:[~2020-01-29 21:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 18:02 Geert Uytterhoeven
2020-01-29 21:08 ` Mat Martineau [this message]
2020-01-30 8:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.21.2001291246140.9282@cmossx-mobl1.amr.corp.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=cpaasch@apple.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®