From: mroos@linux.ee
To: Grant Likely <grant.likely@secretlab.ca>
Cc: David Miller <davem@davemloft.net>,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: SBus devices sometimes detected, sometimes not
Date: Wed, 18 May 2011 16:59:45 +0300 (EEST) [thread overview]
Message-ID: <alpine.SOC.1.00.1105181149290.9877@math.ut.ee> (raw)
In-Reply-To: <BANLkTikhKqcpdadpM3RQdYvDrPn46_v6_Q@mail.gmail.com>
> It would be good to know the exact failure mode, so we need to know if
> of_driver_match_device() is setting of_match which is subsequently
> getting cleared, or if of_driver_match_device() isn't getting called
> at all. Meelis, can you add something like the following code to
> include/linux/of_device.h in the of_driver_match_device() function
> between the of_match_device() call and the return statement:
>
> if (dev->of_match)
> printk("found match; node=%s, driver=%s\n",
> dev->of_node->full_name, drv->name);
>
Tried it with todays 2.6.39-rc7-00211-gc1d10d1. It was harder to
reproduce this time, about 1 time out of 10.
In normal operation:
[ 77.794877] found match; node=/sbus@1f,0/SUNW,hme@0,8c00000, driver=hme
[ 77.872379] sunhme.c:v3.10 August 26, 2008 David S. Miller (davem@davemloft.net)
[ 77.962865] eth0: HAPPY MEAL (SBUS) 10/100baseT Ethernet 08:00:20:88:6d:6a
In case of error (bpp show only as an example that some things work):
[ 70.312166] found match; node=/sbus@1f,0/SUNW,bpp@e,c800000, driver=bpp
[ 70.389649] parport0: sunbpp at 0x1ffec800000
[ 70.477720] found match; node=/sbus@1f,0/SUNW,hme@0,8c00000, driver=hme
[ 70.578023] found match; node=/sbus@1f,0/QLGC,isp@1,10000, driver=qpti
[ 70.915544] hme: probe of f006be34 failed with error -22
[ 70.978825] qpti: probe of f00798c4 failed with error -22
--
Meelis Roos (mroos@linux.ee)
next prev parent reply other threads:[~2011-05-18 13:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.SOC.1.00.1105021259220.6200@math.ut.ee>
2011-05-17 20:43 ` David Miller
2011-05-18 4:29 ` Grant Likely
2011-05-18 13:59 ` mroos [this message]
2011-05-18 15:27 ` [PATCH] of: fix race when matching drivers Milton Miller
2011-05-18 15:41 ` Grant Likely
2011-05-18 15:47 ` Grant Likely
2011-05-18 15:45 ` Josip Rodin
2011-05-18 16:21 ` Grant Likely
2011-05-18 17:03 ` Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.SOC.1.00.1105181149290.9877@math.ut.ee \
--to=mroos@linux.ee \
--cc=davem@davemloft.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®